authz/github: do not recommend groupsCacheTTL, document allowGroupsPermissionsSync #24528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying subscribers in CODENOTIFY files for diff f0e9c1e...caf61b1.
|
bobheadxi
changed the title
|
@unknwon I'm starting to think, should |
it is in fact required IMO... it's probably just not easy to validate in our current code structure? |
unknwon
approved these changes
Sep 2, 2021
bobheadxi
deleted the
groupscachettl-dont-recommend-enabling-groupsCacheTTL
branch
now enforced here: #24561 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding example value makes
groupsCacheTTLa recommended default, which we no longer want to push for. This PR makes the experimental status and niche use case more apparent, and removes the example.Also documents the
allowGroupsPermissionsSyncintroduced in #24328