Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: codemod ExtensionCard component to CSS modules #24782

Merged
merged 5 commits into from Sep 10, 2021
Merged

web: codemod ExtensionCard component to CSS modules #24782

merged 5 commits into from Sep 10, 2021

Conversation

valerybugakov
Copy link
Member

@valerybugakov valerybugakov commented Sep 9, 2021 •
edited

Context

This PR results from the global-css-to-css-modules codemod application with some manual fixes, caused by the usage of global CSS classes tied to a React component in other parts of the codebase: e.g., .sidebar class used outside of the <Sidebar /> component.

Changes

  • The ExtensionCard stylesheet is converted to the CSS module.

@valerybugakov valerybugakov added frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. dx Issues and PRs related to developer experience concerns CSS Modules migration labels Sep 9, 2021
@valerybugakov valerybugakov self-assigned this Sep 9, 2021
@sourcegraph-bot sourcegraph-bot mentioned this pull request Sep 9, 2021
Closed
54 tasks
@valerybugakov valerybugakov marked this pull request as ready for review September 9, 2021 12:41
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Sep 9, 2021 •
edited

Notifying subscribers in CODENOTIFY files for diff 9724fc3...3352eee.

Notify File(s)
@limitedmage client/web/src/enterprise/code-monitoring/snapshots/CodeMonitoringPage.test.tsx.snap
client/web/src/enterprise/code-monitoring/components/snapshots/FormActionArea.test.tsx.snap

umpox
umpox approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@umpox umpox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@valerybugakov valerybugakov merged commit d03b64b into main Sep 10, 2021
@valerybugakov valerybugakov deleted the vb/css-modules-codemod-web-extension-card branch September 10, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umpox umpox umpox approved these changes

@tjkandala tjkandala tjkandala approved these changes

@limitedmage limitedmage Awaiting requested review from limitedmage

@5h1rU 5h1rU Awaiting requested review from 5h1rU

Assignees

@valerybugakov valerybugakov

Labels
dx Issues and PRs related to developer experience concerns frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@valerybugakov @sourcegraph-bot @umpox @tjkandala