Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Symbol sidebar performance through useConnection + Apollo #24836

Merged
merged 8 commits into from Sep 16, 2021

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Sep 10, 2021

The symbols for a specific blob in a specific revision are not going to change. We can safely cache this result and render quicker when navigating between sidebar tabs

  • Migrate from FilteredConnection to useConnection
  • Cache results through Apollo
SymbolSidebarBeforeAfter2.mp4

Closes #24877

Closes #24408

@github-actions github-actions bot added the frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. label Sep 10, 2021
@umpox umpox marked this pull request as draft September 10, 2021 12:27
@umpox umpox changed the title Improve symbols sidebar performance Improve Symbol sidebar performance through useConnection + Apollo Sep 10, 2021
@umpox umpox marked this pull request as ready for review September 10, 2021 13:38
@umpox umpox requested review from eseliger, valerybugakov, 5h1rU and a team and removed request for eseliger September 10, 2021 13:38
Copy link
Contributor

@tjkandala tjkandala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to see this component refactored as well!

Copy link
Member

@valerybugakov valerybugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@umpox umpox merged commit dd213ae into main Sep 16, 2021
@umpox umpox deleted the tr/symbol-sidebar-perf branch September 16, 2021 08:21
@umpox umpox added the UI performance Improvements to the actual page rendering performance as well as perceived performance. label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. UI performance Improvements to the actual page rendering performance as well as perceived performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Apollo Client for Symbols sidebar Symbols sidebar: Serve cached data instead of refetching
3 participants