Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove start.sh and switch to sg to run dev environment #25505

Merged
merged 3 commits into from Sep 29, 2021
Merged

Conversation

mrnugget
Copy link
Contributor

2 weeks ago, in #24988, we announced that we'll remove start.sh in 2 weeks. Time's up.

This the majority of start.sh but leaves a message in it saying that we switched to sg and where to find documentation.

It also removes all the shell scripts that start.sh used to boot up the dev environment that we don't need anymore, either because they're built into sg (such as the watchman configuration, wrapper, helper scripts) or because they're now in sg.config.yaml (where we'll step-by-step reduce them by building more into sg).

2 weeks ago, in #24988, we announced that we'll remove `start.sh` in 2 weeks. Time's up.

This the majority of `start.sh` but leaves a message in it saying that
we switched to `sg` and where to find documentation.

It also removes all the shell scripts that `start.sh` used to boot up
the dev environment that we don't need anymore, either because they're
built into `sg` (such as the watchman configuration, wrapper, helper
scripts) or because they're now in `sg.config.yaml` (where we'll
step-by-step reduce them by building more into `sg`).
@mrnugget mrnugget added sg sg, the Sourcegraph developer command dx-announce Tag PRs with this label to include it in the monthly DX email update labels Sep 29, 2021
Copy link
Contributor

@jeanduplessis jeanduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mrnugget
Copy link
Contributor Author

Side note to @bobheadxi @jhchabran: see 8fd2d88. I had to restore dev/docsite.sh because we use docsite check in CI. That's fine for now, I think, but ideally we'd use sg in CI to run this kind of stuff too so it's easy to reproduce locally if something fails. Maybe we can do something like sg install-all && .bin/docsite check or sg run docsite -- new-args etc.

@jhchabran
Copy link
Member

(...) ideally we'd use sg in CI to run this kind of stuff too so it's easy to reproduce locally if something fails. Maybe we can do something like sg install-all && .bin/docsite check or sg run docsite -- new-args etc.

I really like the idea and ideally I believe that the CI should be build on top of clearly identified interface that we use also locally as opposed to custom shell scripts that are made only for the CI (make it harder to maintain and it silos the knowledge). (RFC 484 broach that topic).

It totally ties sg to the main repo though, which is something we probably want to keep in mind.

@mrnugget
Copy link
Contributor Author

It totally ties sg to the main repo though, which is something we probably want to keep in mind.

Yep, but I don't think it's bad. We do have a monorepo and there are disadvantages that come with pulling something out of the repository.

@mrnugget mrnugget merged commit ab7f628 into main Sep 29, 2021
@mrnugget mrnugget deleted the mrn/switch-to-sg branch September 29, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx-announce Tag PRs with this label to include it in the monthly DX email update sg sg, the Sourcegraph developer command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants