New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove start.sh
and switch to sg
to run dev environment
#25505
Conversation
2 weeks ago, in #24988, we announced that we'll remove `start.sh` in 2 weeks. Time's up. This the majority of `start.sh` but leaves a message in it saying that we switched to `sg` and where to find documentation. It also removes all the shell scripts that `start.sh` used to boot up the dev environment that we don't need anymore, either because they're built into `sg` (such as the watchman configuration, wrapper, helper scripts) or because they're now in `sg.config.yaml` (where we'll step-by-step reduce them by building more into `sg`).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Side note to @bobheadxi @jhchabran: see 8fd2d88. I had to restore |
I really like the idea and ideally I believe that the CI should be build on top of clearly identified interface that we use also locally as opposed to custom shell scripts that are made only for the CI (make it harder to maintain and it silos the knowledge). (RFC 484 broach that topic). It totally ties |
Yep, but I don't think it's bad. We do have a monorepo and there are disadvantages that come with pulling something out of the repository. |
2 weeks ago, in #24988, we announced that we'll remove
start.sh
in 2 weeks. Time's up.This the majority of
start.sh
but leaves a message in it saying that we switched tosg
and where to find documentation.It also removes all the shell scripts that
start.sh
used to boot up the dev environment that we don't need anymore, either because they're built intosg
(such as the watchman configuration, wrapper, helper scripts) or because they're now insg.config.yaml
(where we'll step-by-step reduce them by building more intosg
).