Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: add Sentry loader to the development server html template #27582

Merged
merged 1 commit into from Nov 15, 2021
Merged

web: add Sentry loader to the development server html template #27582

merged 1 commit into from Nov 15, 2021

Conversation

valerybugakov
Copy link
Member

Context

The Sentry loader wasn't added to the development server template, and in non-dotcom mode, that's why the ErrorBoundary could throw an error.

Changes

  • The Sentry loader is added to the HTML template used by the Webpack dev server.
  • The Sentry call in the ErrorBoundary is guarded by the existence check.

@valerybugakov valerybugakov added frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. sentry labels Nov 15, 2021
@valerybugakov valerybugakov self-assigned this Nov 15, 2021
@cla-bot cla-bot bot added the cla-signed label Nov 15, 2021
@sourcegraph-bot sourcegraph-bot mentioned this pull request Nov 15, 2021
Closed
28 tasks
@valerybugakov valerybugakov marked this pull request as ready for review November 15, 2021 14:58
umpox
umpox approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@umpox umpox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valerybugakov valerybugakov merged commit 5445509 into main Nov 15, 2021
@valerybugakov valerybugakov deleted the vb/sentry-development-server branch November 15, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umpox umpox umpox approved these changes

@eseliger eseliger Awaiting requested review from eseliger

Assignees

@valerybugakov valerybugakov

Labels
cla-signed frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. sentry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valerybugakov @umpox