Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix e2e tests #2807

Merged
merged 1 commit into from
Mar 18, 2019
Merged

CI: fix e2e tests #2807

merged 1 commit into from
Mar 18, 2019

Conversation

chrismwendt
Copy link
Contributor

@chrismwendt chrismwendt commented Mar 18, 2019 •
edited
Loading

  • Closes the integrations toast, which was preventing focusing of the external service configuration editor
  • Replaces the external service name, which used to be blank but now defaults to the name of the service
  • Sets localStorage to disable toasts

felixfbecker
felixfbecker reviewed Mar 18, 2019
View reviewed changes
web/src/e2e/index.e2e.test.tsx
method?: ReplaceTextMethod
}): Promise<void> {
const selectAllByMethod: Record<ReplaceTextMethod, () => Promise<void>> = {
selectall: async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the two approaches needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta+A doesn't work in input boxes puppeteer/puppeteer#1313

selectall doesn't work in the Monaco editor.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add that in a comment for future readers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding in #2815

@chrismwendt chrismwendt merged commit 75d12aa into master Mar 18, 2019
@chrismwendt chrismwendt deleted the fix-e2e-tests branch March 18, 2019 21:05
@chrismwendt chrismwendt mentioned this pull request Mar 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfbecker felixfbecker felixfbecker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrismwendt @felixfbecker