Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard: Add wildcard popover component #29488

Closed
wants to merge 5 commits into from

Conversation

vovakulikov
Copy link
Contributor

Closes part of #27694
Related to #29054

Context

This PR adds the @floating-ui popover component.

This is an initial implementation of this component without the full support of all possible cases that support the @floating-ui package and without the migration part of our existing popover component (it will be done in a separate PR).

@vovakulikov vovakulikov added the frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. label Jan 6, 2022
@vovakulikov vovakulikov requested a review from a team January 6, 2022 22:16
@vovakulikov vovakulikov self-assigned this Jan 6, 2022
@cla-bot cla-bot bot added the cla-signed label Jan 6, 2022
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jan 6, 2022

Notifying subscribers in CODENOTIFY files for diff 2b75f55...0c7abf5.

Notify File(s)
@sourcegraph/frontend-platform client/wildcard/src/components/Popover/Popover.story.module.scss
client/wildcard/src/components/Popover/Popover.story.tsx
client/wildcard/src/components/Popover/Popover.tsx
client/wildcard/src/components/Popover/README.md
client/wildcard/src/components/Popover/index.ts
client/wildcard/src/components/Popover/utils.ts
client/wildcard/src/components/index.ts

@vovakulikov
Copy link
Contributor Author

Close in favor of #29791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants