Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize colors for JSON syntax highlighting #30105

Merged
merged 2 commits into from Jan 24, 2022
Merged

Customize colors for JSON syntax highlighting #30105

merged 2 commits into from Jan 24, 2022

Conversation

olafurpg
Copy link
Member

Previously, we used the same syntax highlighting color for JSON keys and
values. This commit overrides the color for keys so that it's easier to
distinguish them from values.

Before (current behavior on Cloud)
CleanShot 2022-01-24 at 15 20 44

After (this PR)
CleanShot 2022-01-24 at 15 20 58
CleanShot 2022-01-24 at 15 20 54

@cla-bot cla-bot bot added the cla-signed label Jan 24, 2022
eseliger
eseliger approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few generated files in here that should be deleted :)

olafurpg
olafurpg commented Jan 24, 2022
View reviewed changes
Copy link
Member Author

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me fix the gigantic diff first

@olafurpg
Customize colors for JSON syntax highlighting
f105a63 
Previously, we used the same syntax highlighting color for JSON keys and
values. This commit overrides the color for keys so that it's easier to
distinguish them from values.

**Before (current behavior on Cloud)**
![CleanShot 2022-01-24 at 15 20 44](https://user-images.githubusercontent.com/1408093/150800080-d9fb3e7c-581c-49ed-a0df-4158b3e48ceb.png)

**After (this PR)**
![CleanShot 2022-01-24 at 15 20 58](https://user-images.githubusercontent.com/1408093/150800132-318d13a3-516c-4950-ad32-b3eecbef9cc8.png)
![CleanShot 2022-01-24 at 15 20 54](https://user-images.githubusercontent.com/1408093/150800144-a06ae4f7-6442-42dd-886e-b8855eed1b2d.png)
olafurpg
olafurpg commented Jan 24, 2022
View reviewed changes
Copy link
Member Author

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an entry to the changelog

@olafurpg olafurpg enabled auto-merge (squash) January 24, 2022 14:29
mrnugget
mrnugget approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@mrnugget mrnugget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@olafurpg olafurpg merged commit 30424e6 into main Jan 24, 2022
@olafurpg olafurpg deleted the olafurpg/hl-json branch January 24, 2022 14:36
davejrt pushed a commit that referenced this pull request Jan 26, 2022
@olafurpg @davejrt
Customize colors for JSON syntax highlighting (#30105)
d2e3bc7
davejrt pushed a commit that referenced this pull request Feb 15, 2022
@olafurpg @davejrt
Customize colors for JSON syntax highlighting (#30105)
ae1abbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrnugget mrnugget mrnugget approved these changes

@eseliger eseliger eseliger approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olafurpg @mrnugget @eseliger