web: require enabling Chromatic snapshot for every story manually #30331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerybugakov
added
the
frontend-platform
This was referenced Jan 28, 2022
umpox
reviewed
Jan 28, 2022
valerybugakov
force-pushed
the
vb/disable-chromatic
branch
from
4d0f8e1
to
a7d7185
Compare
valerybugakov
force-pushed
the
vb/disable-chromatic
branch
from
a7d7185
to
3a08e9d
Compare
valerybugakov
force-pushed
the
vb/disable-chromatic
branch
from
3a08e9d
to
8772e2e
Compare
|
Codenotify: Notifying subscribers in OWNERS files for diff 9b27c2e...8772e2e.
|
eseliger
approved these changes
Feb 14, 2022
courier-new
approved these changes
Feb 14, 2022
umpox
approved these changes
Feb 15, 2022
pietrorosa77
pushed a commit
that referenced
this pull request
Feb 15, 2022
pietrorosa77
added a commit
that referenced
this pull request
Feb 15, 2022
* list pending invites * added pending invitations for org grapql method * pending invitations page update * added revoke link and copy link * fixed avatar url and gap in pending invites * added resend invite * try/catch on resend invite * Update cmd/frontend/graphqlbackend/org_invitations.go Co-authored-by: Milan Freml <kopancek@users.noreply.github.com> * Update go.sum Co-authored-by: Milan Freml <kopancek@users.noreply.github.com> * Update internal/database/org_invitations.go Co-authored-by: Milan Freml <kopancek@users.noreply.github.com> * `Card`: Use raw values rather than CSS vars (#31233) * web: require enabling Chromatic snapshot for every story manually (#30331) * Update invite null text and differentiate between two cases (#31168) * doc: update Chromatic docs (#31239) * Experimental ref panel: allow users to collapse top-level lists (#31241) This fixes #30974 by allowing users to collapse the "Definitions", "References" and "Implementations" lists. * search contexts: fix query editing and move error alert inside the form (#31232) * fixing review comments it1 * prettify files Co-authored-by: Milan Freml <kopancek@users.noreply.github.com> Co-authored-by: Tom Ross <tom@umpox.com> Co-authored-by: Valery Bugakov <skymk1@gmail.com> Co-authored-by: Philipp Spiess <hello@philippspiess.com> Co-authored-by: Thorsten Ball <mrnugget@gmail.com> Co-authored-by: Rok Novosel <rok@sourcegraph.com>
davejrt
pushed a commit
that referenced
this pull request
Feb 15, 2022
davejrt
pushed a commit
that referenced
this pull request
Feb 15, 2022
* list pending invites * added pending invitations for org grapql method * pending invitations page update * added revoke link and copy link * fixed avatar url and gap in pending invites * added resend invite * try/catch on resend invite * Update cmd/frontend/graphqlbackend/org_invitations.go Co-authored-by: Milan Freml <kopancek@users.noreply.github.com> * Update go.sum Co-authored-by: Milan Freml <kopancek@users.noreply.github.com> * Update internal/database/org_invitations.go Co-authored-by: Milan Freml <kopancek@users.noreply.github.com> * `Card`: Use raw values rather than CSS vars (#31233) * web: require enabling Chromatic snapshot for every story manually (#30331) * Update invite null text and differentiate between two cases (#31168) * doc: update Chromatic docs (#31239) * Experimental ref panel: allow users to collapse top-level lists (#31241) This fixes #30974 by allowing users to collapse the "Definitions", "References" and "Implementations" lists. * search contexts: fix query editing and move error alert inside the form (#31232) * fixing review comments it1 * prettify files Co-authored-by: Milan Freml <kopancek@users.noreply.github.com> Co-authored-by: Tom Ross <tom@umpox.com> Co-authored-by: Valery Bugakov <skymk1@gmail.com> Co-authored-by: Philipp Spiess <hello@philippspiess.com> Co-authored-by: Thorsten Ball <mrnugget@gmail.com> Co-authored-by: Rok Novosel <rok@sourcegraph.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The Frontend Platform team started looking into ways to limit our Chromatic spending that went out of hand. And as a first remediation measure, we proposed disabling snapshotting all stories by default. Snapshotting can be enabled for an individual story by adding
disableSnapshot: falseto story parameters. That way, it becomes a more conscious decision, and engineers can decide what's important to snapshot.Here's the list of issues to track the progress per team.
Changes
wildcardandsharedstories.Results
We have 321 snapshots in the Chromatic diff. There's still room for improvement as @eseliger mentioned in batchers PR — we can still merge some stories or disable specific viewports for some of them.