Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go-mockgen #31597

Merged
merged 1 commit into from Feb 22, 2022
Merged

chore: update go-mockgen #31597

merged 1 commit into from Feb 22, 2022

Conversation

efritz
Copy link
Contributor

@efritz efritz commented Feb 21, 2022

go-mockgen v1.1.3 has the incorrect version string, meaning that it re-downloaded go-mockgen on every go-generate command. This bumps the version so that we have a stable version string.

Should improve build times.

Test plan

Affects the build, not the product.

@efritz efritz added dx Issues and PRs related to developer experience concerns dx-announce Tag PRs with this label to include it in the monthly DX email update labels Feb 21, 2022
@efritz efritz requested review from bobheadxi and a team February 21, 2022 23:46
@efritz efritz self-assigned this Feb 21, 2022
@cla-bot cla-bot bot added the cla-signed label Feb 21, 2022
@sourcegraph-bot
Copy link
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 33f09a6...efb3f32.

Notify File(s)
@beyang enterprise/cmd/precise-code-intel-worker/internal/worker/mock_iface_test.go
enterprise/cmd/precise-code-intel-worker/internal/worker/mock_worker_store_test.go
internal/search/job/job_mock_test.go
@bobheadxi docker-images/prometheus/cmd/prom-wrapper/mocks/prometheus_mock.go
@camdencheek internal/search/job/job_mock_test.go
@eseliger enterprise/cmd/frontend/internal/executorqueue/handler/mock_iface_test.go
enterprise/cmd/frontend/internal/executorqueue/queues/batches/mock_iface_test.go
enterprise/internal/batches/reconciler/mock_changeset_source_test.go
enterprise/internal/batches/syncer/mock_iface_test.go
@indradhanush cmd/gitserver/server/mock_iface_test.go
internal/gitserver/mock_client.go
@keegancsmith cmd/symbols/internal/api/mock_iface_test.go
cmd/symbols/internal/fetcher/mock_iface_test.go
internal/search/job/job_mock_test.go
@ryanslade cmd/gitserver/server/mock_iface_test.go
internal/gitserver/mock_client.go
@sourcegraph/code-insights-backend enterprise/internal/insights/background/mock_repo_store.go
enterprise/internal/insights/compression/mock_commit_store.go
enterprise/internal/insights/discovery/mock_indexable_repos_lister.go
enterprise/internal/insights/discovery/mock_repo_store.go
enterprise/internal/insights/discovery/mock_setting_store.go
enterprise/internal/insights/store/mock_store_dataseriesstore.go
enterprise/internal/insights/store/mock_store_insightmetadatastore.go
enterprise/internal/insights/store/mock_store_interface.go
@unknwon internal/authz/mock_sub_repo_perms_checker.go
internal/authz/mock_sub_repo_perms_getter.go

@efritz efritz merged commit b9886b1 into main Feb 22, 2022
@efritz efritz deleted the ef/update-go-mockgen branch February 22, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed dx Issues and PRs related to developer experience concerns dx-announce Tag PRs with this label to include it in the monthly DX email update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants