web/settings: Fix quick action selection

[yowayb]

• Fixed Fix selection after running a settings quick action #2756,
• Replaced setProperty() (internal) calls with modify() (exported, typed)

Test plan

Note: no component snapshots (https://kentcdodds.com/blog/effective-snapshot-testing)

• Before/after screenshots of a few combinations of Settings Actions

Questions

• Would a Percy visual test be appropriate?

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

The reviewers' guide for accepting the contribution.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

The reviewers' guide for accepting the contribution.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

The reviewers' guide for accepting the contribution.

[yowayb]

Screenshots

Click "Search: show # before/after lines":

Before	After (the selection of the 3 is hard to see)

---

Click "Search: show # before/after lines", then "Add search snippet":

Before	After (no change)

---

Click "Add search snippet", then "Search: show # before/after lines" :

Before	After (the selection of the 3 is hard to see)

---

Click "Search: show # before/after lines", then "Add quick link" (note: this was fixed by changing the placeholder text, because this Action specifies a selection. Without this fix, the entire array after "quicklinks": would be selected):

Before	After

[yowayb]

@sourcegraph/contribution-reviewers