all: use alpine-3.14 #34508
Merged
all: use alpine-3.14 #34508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a 3.14 image available, but when we introduced it we ran into
problems using it. This is an attempt to update all images to use the
newer version of alpine. If anything breaks in CI, I will revert the
specific image which is breaking.
ruplacer --go \
sourcegraph/alpine-3.12:142406_2022-04-14_8836ac3499f4@sha256:4681a48d1fb9a73fef1b540c08b3411f797351bbeda749f5dca21213a1e71526 \
sourcegraph/alpine-3.14:142406_2022-04-14_8836ac3499f4@sha256:2a2d1cbaec78882661fe1aa5b0a4af0c23a37be2ea9ff8aadc2da5b80852c233
Test Plan: main dry run on CI to test docker image building and
integration testing.
Symbols is failing to build, which also means server is failing to build. Trying this out again with those images set to apline 3.12.
|
@chrismwendt I know you have been making some changes to how we build symbols. Any idea why bumping the alpine distro to 3.14 causes the build to fail? |
|
@chrismwendt the sanity check fails: |
|
I pushed a fix which adds I'm guessing sourcegraph/alpine-3.12 already had those packages installed and 3.14 doesn't, but I'm not 100% sure 🤷 |
This reverts commit a322e6c.
|
@chrismwendt thanks, that resolved it. Now the issue is a legit one, the version of postgres changes thanks to the different alpine and our CI caught a legit issue :) |
this needs to be the same version as postgres, otherwise you run into linking issues.
|
The road was long, but CI is green. |
|
Note: I am adding a lot of reviewers here, mainly for awareness than actually reviewing the code. The actual code changes are boring, the PR description is more important. |
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 7c6bfb1...6f68853.
|
|
Codenotify: Notifying subscribers in OWNERS files for diff 7c6bfb1...6f68853.
|
My spidey senses are worried we don't have the needed treesitter libs.
dcomas
approved these changes
May 4, 2022
thiswayman
pushed a commit
that referenced
this pull request
May 4, 2022
We have a 3.14 image available, but when we introduced it we ran into problems
using it. This updates all images to use the newer version of alpine.
ruplacer --go \
sourcegraph/alpine-3.12:142406_2022-04-14_8836ac3499f4@sha256:4681a48d1fb9a73fef1b540c08b3411f797351bbeda749f5dca21213a1e71526 \
sourcegraph/alpine-3.14:142406_2022-04-14_8836ac3499f4@sha256:2a2d1cbaec78882661fe1aa5b0a4af0c23a37be2ea9ff8aadc2da5b80852c233
I also had to pin postgresql in the server image since we can't upgrade it
otherwise customer upgrades fail (incompatible on disk data). Additionally we
had to include libstc++ and libgcc for tree sitter.
Risks: I am relying on our CI to catch problems with this upgrade. The main
risks here are us not testing things which exercise non-go binaries that rely
on shared libraries. What comes to mind is things like p4 and tree-sitter, I
am unsure if they get properly exercised. However, I think now is a good time
to land a change like this since we have a lot of time until branch cut.
Test Plan: main dry run on CI to test docker image building and integration
testing.
This was referenced May 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I am adding a lot of reviewers here, mainly for awareness than actually reviewing the code. The actual code changes are boring, the PR description is more important.
We have a 3.14 image available, but when we introduced it we ran into problems using it. This updates all images to use the newer version of alpine.
I also had to pin postgresql in the server image since we can't upgrade it otherwise customer upgrades fail (incompatible on disk data). Additionally we had to include
libstc++andlibgccfor tree sitter.Risks: I am relying on our CI to catch problems with this upgrade. The main risks here are us not testing things which exercise non-go binaries that rely on shared libraries. What comes to mind is things like p4 and tree-sitter, I am unsure if they get properly exercised. However, I think now is a good time to land a change like this since we have a lot of time until branch cut.
Test Plan: main dry run on CI to test docker image building and integration testing.