Improve Percy + accessibilityAudit test coverage on commits Page
#34960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitstart-sourcegraph
force-pushed
the
contractors/SG-34403-5
branch
from
dec91be
to
4e30310
Compare
gitstart-sourcegraph
changed the title
commits Pagecommits Page
umpox
reviewed
May 6, 2022
umpox
reviewed
May 6, 2022
| @@ -154,6 +154,7 @@ export const RepositoryCommitsPage: React.FunctionComponent<React.PropsWithChild | |||
| history={props.history} | |||
| hideSearch={true} | |||
| location={props.location} | |||
| listComponent="div" | |||
There was a problem hiding this comment.
Suggested change
| listComponent="div" |
What is the failure here? is it because there is no
I think we still ideally want this to be a list, as it definitely helps understand each item (e.g. commit 10 out of 20)
umpox
reviewed
May 6, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently have visual regression + accessibility audit tests on a series of user journeys within Sourcegraph. A lot of core functionality is still not covered, it reduces our confidence in shipping changes as UI/accessibility bugs can be introduced without our awareness.
Implementation
For this Commits Page
Refs
Sourcegraph Issue
Gitstart Ticket
Test plan
Run
ENTERPRISE=1 yarn build-webRun
ENTERPRISE=1 HEADLESS=true yarn _test-integration client/web/src/integration/repository.test.tsTest should pass successfully
App preview:
Check out the client app preview documentation to learn more.