Add an example for branding site configuration
#3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadlerj
reviewed
May 2, 2019
There was a problem hiding this comment.
lgtm (assuming it works :)). One request before merging: find an example of where we have text that says "note: this is a paid enterprise feature" (or whatever the text is), and add that to the docs for this setting. It's not actually blocked in the code, so just adding a note/alert in the comments is sufficient for now.
e.g. in the docs on this page? https://docs.sourcegraph.com/integration/google_gsuite I can't find many other examples.
sqs
approved these changes
May 2, 2019
|
Added to pricing page too: sourcegraph/about#115 |
Codecov Report
|
|
@dadlerj Updated. I copied the wording/addition from the
|
This adds an example to the schema for the `branding` property to showcase on the docs page how to use it.
mrnugget
force-pushed
the
docs/branding_example
branch
from
129c6ca
to
3528c53
Compare
KattMingMing
approved these changes
May 2, 2019
dadlerj
approved these changes
May 3, 2019
ijsnow
pushed a commit
that referenced
this pull request
May 7, 2019
This adds an example to the schema for the `branding` property to showcase on the docs page how to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an example to the schema for the
brandingproperty toshowcase on the docs page how to use it.
Looks like this:
Relevant: sourcegraph/about#114
Test plan: manually looked at docs site to check whether it's correctly rendered