dev/sg: add envOverrides option for sets to override command env

[bobheadxi]

Right now, command env takes precedence over set env. I'm scared to change this, so instead I added envOverrides and prop-drilled it to override whatever env is set on the command.

Test plan

Tested in #38319 , frontend-e2e tests work now

[bobheadxi]

Current dependencies on/for this PR:

• main
  • PR dev/sg: add envOverrides option for sets to override command env #38318 👈
    • PR dev/sg: fix enterprise-e2e set, fix frontend-e2e test preamble #38319

This comment was auto-generated by Graphite.

[sourcegraph-bot]

Codenotify: Notifying subscribers in OWNERS files for diff 1a2cb5e...dd11827.

Notify	File(s)
@mrnugget	dev/sg/internal/run/command.go dev/sg/internal/run/run.go dev/sg/internal/sgconf/config.go dev/sg/sg_run.go dev/sg/sg_start.go
@sourcegraph/dev-experience	dev/sg/internal/run/command.go dev/sg/internal/run/run.go dev/sg/internal/sgconf/config.go dev/sg/sg_run.go dev/sg/sg_start.go

[jhchabran]

Right now, command env takes precedence over set env. I'm scared to change this, so instead I added envOverrides and prop-drilled it to override whatever env is set on the command.

Yeah, it broke stuff in the past, see #34895

I think we should get this sorted as you mentioned over Slack, before we slowly start turning it in a nightmare with exceptions mechanisms

[bobheadxi]

I think we should get this sorted as you mentioned over Slack, before we slowly start turning it in a nightmare with exceptions mechanisms

I think this is not a bad way to go - define a precedence, and allow a few override mechanisms. Right now I think this might be the right band-aid

[bobheadxi]

That said, I suppose there is a workaround without code changes - we set the env as part of the command script itself

[bobheadxi]

Found a neater(?) hack: #38327