web: Remove thread-loader from Webpack #39560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
frontend-platform
plibither8
requested review from
valerybugakov,
jasongornall and
mrnugget
and removed request for
mrnugget
valerybugakov
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged before #39381.
The
SentryWebpackPlugindoes not work withthread-loader, sincethread-loaderdoesn't have access to webpack options, thus it cannot accessqueryparams of the loader. See getsentry/sentry-webpack-plugin#272 (comment).Secondly, thread-loader itself has not shown any substantial performance or build-time improvements.
thread-loaderthread-loaderTest plan
Builds are passing with green checks without
thread-loader.App preview:
Check out the client app preview documentation to learn more.