[SG-39284] Upgrade yarn to the latest version #39728
Conversation
gitstart-sourcegraph
added
gitstart
gitstart-sourcegraph
force-pushed
the
contractors/SG-39284.base
branch
2 times, most recently
from
8b4ac1c
to
90f0c27
Compare
There was a problem hiding this comment.
@gitstart-sourcegraph, please force-push to remove the latest commit from the git history of our the repository. Removing all zip archives committed to the repo is important to avoid polluting git history with large files.
We do not want to use the Plug'n'Play feature with zero installs. It's mentioned in the issue description. Initially, we want to use the node-modules nodeLinker to minimize the changes required for the upgrade.
We want to upgrade to the latest version of yarn with minimal changes required in our codebase. Mainly it should be commands and some configuration files. Let me know if you bump into any sweeping changes while working on the task.
|
:D thanks @valerybugakov actually we are going to ask you about it too |
gitstart-sourcegraph
changed the title
gitstart-sourcegraph
force-pushed
the
contractors/SG-39284.base
branch
from
90f0c27
to
e1e8ae8
Compare
…thub.com/sourcegraph/sourcegraph into contractors/SG-39284.base
There was a problem hiding this comment.
Let's try removing web-ext package, which is not used in the repo anymore, to remove transitive dependency on the dtrace-provider package, which causes failure here.
Also, let's explicitly add @sentry/cli to our package.json to see if it resolves another issue reported by the build linked above.
…thub.com/sourcegraph/sourcegraph into contractors/SG-39284.base
…thub.com/sourcegraph/sourcegraph into contractors/SG-39284.base
…thub.com/sourcegraph/sourcegraph into contractors/SG-39284.base
…thub.com/sourcegraph/sourcegraph into contractors/SG-39284.base
…thub.com/sourcegraph/sourcegraph into contractors/SG-39284.base
|
As discussed on Slack, we may need to upgrade Yarn on |
…thub.com/sourcegraph/sourcegraph into contractors/SG-39284.base
|
no longer seeing the issue with |
client/web/package.json
Outdated
| "test:regression": "yarn task:mocha './src/regression/**/*.test.ts' --exit", | ||
| "test": "yarn run -T jest --testPathIgnorePatterns end-to-end --testPathIgnorePatterns regression integration", | ||
| "task:mocha": "yarn run -T cross-env TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' mocha", | ||
| "test:regression": "yarn run -T task:mocha './src/regression/**/*.test.ts' --exit", |
There was a problem hiding this comment.
Might the -T flag here be the reason for this CI failure?
client/vscode/package.json
Outdated
| @@ -224,18 +224,18 @@ | |||
| "prewatch": "yarn build-inline-extensions", | |||
| "vscode:prepublish": "yarn build-inline-extensions && yarn build", | |||
| "build-inline-extensions": "node scripts/build-inline-extensions", | |||
| "task:gulp": "cross-env NODE_OPTIONS=\"--max_old_space_size=8192\" gulp", | |||
| "task:gulp": "yarn cross-env NODE_OPTIONS=\"--max_old_space_size=8192\" gulp", | |||
There was a problem hiding this comment.
Should we use the -T flag here in the same manner we do it for the task:gulp NPM script in the web package?
…thub.com/sourcegraph/sourcegraph into contractors/SG-39284.base
…thub.com/sourcegraph/sourcegraph into contractors/SG-39284.base
gitstart-sourcegraph
force-pushed
the
contractors/SG-39284.base
branch
from
ac55f0d
to
a55c0f8
Compare
There was a problem hiding this comment.
Pushed a couple of fixes and triggered the main-dry-run build.
Description
Setup:
Migrate:
yarn-deduplicatepackage, replaceyarn deduplicatewith nativeyarn dudupe—mutex—silient—ignore-script—ignore-engine--cwd package/pathwithworkspace package_nameyarnin front of binary script in scripts config, ex.cross-env->yarn cross-envclient/extension-api/node_modules.yarn/cacheRefs
Sourcegraph Issue
Gitstart Ticket
Test plan
Ensure that CI checks are green.
App preview:
Check out the client app preview documentation to learn more.