Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore crates.io syncer in worker job #40755

Merged
merged 1 commit into from Aug 24, 2022
Merged

Restore crates.io syncer in worker job #40755

merged 1 commit into from Aug 24, 2022

Conversation

mrnugget
Copy link
Contributor

This job was accidentally removed in #39742 as part of the
dependencies_job.go.

The commit here restores it by restoring the cratessyncer in a
separate worker job.

That fixes #37698.

Test plan

  • Manually decreased the interval time, added debug logging, ran sg start and checked that worker ran.

@mrnugget
Restore crates.io syncer in worker job
0925550 
This job was accidentally removed in #39742 as part of the
`dependencies_job.go`.

The commit here restores it by restoring the `cratessyncer` in a
separate worker job.

That fixes #37698.
@cla-bot cla-bot bot added the cla-signed label Aug 23, 2022
@sourcegraph-bot
Copy link
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 040446a...0925550.

Notify File(s)
@efritz cmd/worker/internal/codeintel/crates_syncer.go
cmd/worker/shared/main.go
@sourcegraph/delivery doc/admin/workers.md

olafurpg
olafurpg approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mrnugget ! 🙏🏻

@mrnugget mrnugget merged commit 12baa90 into main Aug 24, 2022
@mrnugget mrnugget deleted the mrn/restore-crates-syncer branch August 24, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

@efritz efritz Awaiting requested review from efritz

@tjdevries tjdevries Awaiting requested review from tjdevries

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust: follow up on post-merge review comments
3 participants
@mrnugget @sourcegraph-bot @olafurpg