syntax-highlighter: Use sourcegraph/syntect, not slimsag/syntect. #40783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varungandhi-src
force-pushed
the
vg/use-sg-syntect
branch
from
0e4a382
to
5b331c9
Compare
tjdevries
approved these changes
Aug 25, 2022
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tjdevries can you double-check that there's no behavior change with this? I tested a few languages visually.
Test plan
The tests in sourcegraph/syntect are passing. Visually inspected the highlighting for different languages like JavaScript, Ruby and Markdown with this change -- didn't see any regression.