Make fuzzy finder modal wide again #41736
Conversation
The width of the fuzzy finder modal recently became very narrow. I wasn't able to track down the exact PR that impacted the width, but at some point the priority of the Wildcard `Modal` component overwrote the custom `width: 80vw` style we defined specifically for the fuzzy finder. This commit fixes the priority by use an `id` attribute instead of `class`.
|
Added the 4.0 label since this is a bugfix, not a new feature. |
Any advice on how to fix the priority without using |
There was a problem hiding this comment.
It should not be happening — the Wildcard styles should have lower priority than component styles. This bug surfaces the fundamental issue with CSS rules order in the production environment that is different from what we have in the development env.
Let me look into the root cause. If the fix takes a lot of time, we can fix this side-effect to get it into the 4.0 release.
Merge could not be authorized
|
@valerybugakov have you been able to investigate the root cause of this issue? |
There was a problem hiding this comment.
Hey @olafurpg, sorry for the delay!
Here's the Slack thread if you're interested in more context and the tracking issue to address the underlying problem. I pushed the update to this PR that patches the side-effect.
|
Thank you @valerybugakov ! 🙏🏻 |
* Make fuzzy finder modal wide again The width of the fuzzy finder modal recently became very narrow. I wasn't able to track down the exact PR that impacted the width, but at some point the priority of the Wildcard `Modal` component overwrote the custom `width: 80vw` style we defined specifically for the fuzzy finder. This commit fixes the priority by use an `id` attribute instead of `class`. * web: make fuzzy finder modal wide again Co-authored-by: Valery Bugakov <skymk1@gmail.com>
The width of the fuzzy finder modal recently became very narrow. I wasn't able to track down the exact PR that impacted the width, but at some point the priority of the Wildcard
Modalcomponent overwrote the customwidth: 80vwstyle we defined specifically for the fuzzy finder. This commit fixes the priority by use anidattribute instead ofclass.Before
After
Test plan
Manually tested the PR locally and posted screenshots in the PR description.
App preview:
Check out the client app preview documentation to learn more.