Append OIDC logins (success/failure) to security events. #44467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 6334795...fbdb723.
|
willdollman
approved these changes
Nov 16, 2022
enterprise/cmd/frontend/internal/auth/openidconnect/middleware.go
Outdated
Show resolved
Hide resolved
| db.SecurityEventLogs().LogEvent(r.Context(), &database.SecurityEvent{ | ||
| Name: database.SecurityEventOIDCLoginFailed, | ||
| URL: r.URL.Path, // don't log OIDC query params | ||
| AnonymousUserID: fmt.Sprintf("unknown OIDC @ %s", time.Now()), // we don't know have a reliable user identify at the time of the failure |
There was a problem hiding this comment.
Suggested change
| AnonymousUserID: fmt.Sprintf("unknown OIDC @ %s", time.Now()), // we don't know have a reliable user identify at the time of the failure | |
| AnonymousUserID: fmt.Sprintf("unknown OIDC @ %s", time.Now()), // We don't have a reliable user identity at the time of the failure |
There was a problem hiding this comment.
Is time.Now() necessary as we also have a Timestamp field?
There was a problem hiding this comment.
I think no, but I wanted to make that unique (more or less); we'd normally use a cookie value for the AnonymousUserID, but we haven't got anything in this case.
enterprise/cmd/frontend/internal/auth/openidconnect/middleware.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Will Dollman <will.dollman@sourcegraph.com>
Co-authored-by: Will Dollman <will.dollman@sourcegraph.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expand security events with a new
SecurityEventOIDCLoginSucceededandSecurityEventOIDCLoginFailedpair and hook it up to the correct place.Test plan