Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authz: Fix Postgres row deadlock #4517

Merged
merged 1 commit into from Jun 14, 2019
Merged

authz: Fix Postgres row deadlock #4517

merged 1 commit into from Jun 14, 2019

Conversation

tsenart
Copy link
Contributor

@tsenart tsenart commented Jun 14, 2019

@tsenart tsenart added this to the 3.5 milestone Jun 14, 2019
@tsenart tsenart requested review from beyang and kzh June 14, 2019 20:57
@tsenart tsenart added auth bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. bitbucket Issues that occur with the Bitbucket Server code host labels Jun 14, 2019
@beyang
Copy link
Member

beyang commented Jun 14, 2019

Review context (from Slack):

beyang  any worries about how now the critical zone (transaction zone) is now smaller that it was before (e.g., it does not include the `load` invocation)?
[1m]
tomas  @beyang: It's OK, because we explicitly use "FOR SHARE" (a read lock) in the first load.

[1m]
beyang  i guess it's okay because it preserves before-after atomicity?
[1m]
tomas  Which blocks even outside of a tx
[1m]
beyang  ah got it
[<1m]
tomas  When the row has been locked with FOR UPDATE

@tsenart tsenart merged commit fe32534 into master Jun 14, 2019
@tsenart tsenart deleted the core/bitbucket-server-authz-fixes branch June 14, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beyang beyang beyang approved these changes

@kzh kzh Awaiting requested review from kzh

Assignees
No one assigned
Labels
auth bitbucket Issues that occur with the Bitbucket Server code host bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior.
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsenart @beyang