New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: remove deprecated authenticatedUser.email #46183
client: remove deprecated authenticatedUser.email #46183
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
e60c2a0
to
6b80bb1
Compare
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 85d7ee6 and 179254b or learn more. Open explanation
|
fb5a412
to
863f3b3
Compare
Not notifying subscribers because the number of notifying subscribers (11) has exceeded the threshold (10). |
863f3b3
to
c9913ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! If the backend is indeed in place then this should work right. Left two very small nits.
Co-authored-by: David Veszelovszki <veszelovszki@gmail.com>
Co-authored-by: David Veszelovszki <veszelovszki@gmail.com>
470cc9e
to
85d7ee6
Compare
Codenotify: Notifying subscribers in OWNERS files for diff 7a6dc29...85d7ee6.
|
The
authenticatedUsers.email
field is deprecated - the equivalent can now be found withauthenticatedUsers.emails.find(email => email.isPrimary)
. This gives more details about the email as well, such as whether it is verified or not, which is required to implement verified email checks (e.g. #46184)https://github.com/sourcegraph/sourcegraph/blob/fb5a412a9c66c4e08a2fb4dab859a765cdedc1ff/cmd/frontend/graphqlbackend/schema.graphql#L5538-L5542
Test plan
Tests pass still
App preview:
Check out the client app preview documentation to learn more.