New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client/web/src/site-admin: Add history panel #49842
Conversation
Co-authored-by: Milan Freml <kopancek@users.noreply.github.com>
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits b249fa6 and ccf9b20 or learn more. Open explanation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement, good job :)
Added some comments.
Looks great Indra, I think this is going to be really helpful for Site Admins! Have you played around with adding colors to the diffs by any chance? Something like this? I feel like visually it would be kind of nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a second round of comments.
Ongoing fixes LGTM, waiting for new commits :)
@varsanojidan I did not. For the first version we decided to ship it without colors to start with. |
Without this the loading spinner loads outisde the component and it looks ugly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think you need to add a horizontal line in case of an empty diff too?
Let's fix it and
@sashaostrikov Diff will technically never be empty any more since we changed the backend to skip redundant entries. The API spec allows it to be null at the moment which needs to be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock.
Nice job!
Regarding the avatar: It would be nice to have the avatars, but not at the expense of performance. If we figure out a way of displaying avatars without a performance hit, then this would be an example of how to show them: if not: Nevertheless, I think we could change the title of the section to "Change history" and the layout of each row. I also think we can be clear about the changes that happen via file instead of via user. I added wording for this, however I'm not entirely sure if it captures the exact scenario. |
👉 Loom: https://www.loom.com/share/d84dfbf54f3c46d99a67ff79910eadbe
Fixes #46032.
Test plan
App preview:
Check out the client app preview documentation to learn more.