Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user select for feature flag overrides #49932

Merged
merged 1 commit into from Mar 24, 2023
Merged

Add user select for feature flag overrides #49932

merged 1 commit into from Mar 24, 2023

Conversation

eseliger
Copy link
Member

@eseliger eseliger commented Mar 23, 2023

This adds a component to make users selectable by name, instead of id. This should be easier to use. Not the most polished implementation without also overhauling the org selector, but this should be a quick QOL improvement.

Screenshot 2023-03-23 at 22 02 37@2x

Test plan

Verified things work manually.

App preview:

Check out the client app preview documentation to learn more.

This adds a component to make users selectable by name, instead of id. This should be easier to use. Not the most polished implementation without also overhauling the org selector, but this should be a quick QOL improvement.
Copy link
Member

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!!!

@eseliger eseliger merged commit 9210123 into main Mar 24, 2023
32 checks passed
@eseliger eseliger deleted the es/select-user-ff branch March 24, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants