Do not paste text on macOS in e2e tests #5044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasting text was introduced in f2365a5 and doesn't work on my macOS machine. Reading through puppeteer/puppeteer#1313 tells me that other people also couldn't get pasting via Meta+V to work on macOS with Puppeteer. This commit adds an override for macOS while leaving the existing `paste` function as is.
beyang
approved these changes
Aug 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #5044 +/- ##
==========================================
+ Coverage 46.26% 46.26% +<.01%
==========================================
Files 731 731
Lines 44878 44878
Branches 2613 2613
==========================================
+ Hits 20763 20765 +2
+ Misses 22107 22106 -1
+ Partials 2008 2007 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pasting text was introduced in f2365a5 and doesn't work on my macOS machine.
Reading through puppeteer/puppeteer#1313 (and a ton of other GitHub issues and SO questions/answers) tells me that other people also couldn't get pasting via Meta+V to work on macOS with Puppeteer.
This commit adds an override for macOS while leaving the existing
pastefunction as is.