Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for editing Cody messages #51009

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Conversation

SuperAuguste
Copy link
Contributor

@SuperAuguste SuperAuguste commented Apr 21, 2023

Closes #50974

Test plan

Tested locally in VSCode and it seems to work - feel free to suggest additional testing methodologies :)

@sg-e2e-regression-test-bob
Copy link

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.01% (+2.12 kb) 0.02% (+2.12 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits dfb023d and afc1b03 or learn more.

Note: We do not have exact data for 52a6cc3. So we have used data from: afc1b03.
The intended commit has no frontend pipeline, so we chose the last commit with one before it.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really really cool! So cool I went over a bit on the review so please let me know if my suggestions don't make sense 😆
Most of them are just nits, except the new changes allow users to replace with an empty input so requesting a change on that 🙇‍♀️

client/cody-ui/src/chat/TranscriptItem.tsx Outdated Show resolved Hide resolved
client/cody-ui/src/chat/TranscriptItem.tsx Outdated Show resolved Hide resolved
client/cody-ui/src/chat/TranscriptItem.tsx Show resolved Hide resolved
client/cody-ui/src/chat/TranscriptItem.tsx Outdated Show resolved Hide resolved
client/cody/src/chat/ChatViewProvider.ts Outdated Show resolved Hide resolved
client/cody-shared/src/chat/transcript/index.ts Outdated Show resolved Hide resolved
client/cody/webviews/Chat.tsx Outdated Show resolved Hide resolved
client/cody/webviews/Chat.tsx Outdated Show resolved Hide resolved
client/cody-ui/src/chat/TranscriptItem.tsx Outdated Show resolved Hide resolved
@mrnugget
Copy link
Contributor

I pushed two commits that should help with the ESLint errors

@SuperAuguste SuperAuguste force-pushed the auguste/cody-edit-message branch 3 times, most recently from a900c75 to 290365d Compare April 24, 2023 15:55
@SuperAuguste SuperAuguste requested review from abeatrix and a team and removed request for abeatrix April 24, 2023 16:09
Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The update works great on my local vscode instance 👍

@mrnugget
Copy link
Contributor

@SuperAuguste I'm gonna go ahead and merge this. Thanks!

@mrnugget mrnugget merged commit 0c3a030 into main Apr 25, 2023
17 checks passed
@mrnugget mrnugget deleted the auguste/cody-edit-message branch April 25, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to edit and resubmit chat message
4 participants