-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality for editing Cody messages #51009
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits dfb023d and afc1b03 or learn more. Note: We do not have exact data for 52a6cc3. So we have used data from: afc1b03. Open explanation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really really cool! So cool I went over a bit on the review so please let me know if my suggestions don't make sense 😆
Most of them are just nits, except the new changes allow users to replace with an empty input so requesting a change on that 🙇♀️
I pushed two commits that should help with the ESLint errors |
a900c75
to
290365d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The update works great on my local vscode instance 👍
0a40a09
to
18e79b9
Compare
18e79b9
to
dfb023d
Compare
@SuperAuguste I'm gonna go ahead and merge this. Thanks! |
Closes #50974
Test plan
Tested locally in VSCode and it seems to work - feel free to suggest additional testing methodologies :)