Embeddings: simplify batching #51014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camdencheek
force-pushed
the
cc/batch-flush
branch
from
b5366ca
to
c9a8491
Compare
camdencheek
requested review from
jtibshirani and
a team
and removed request for
jtibshirani
camdencheek
force-pushed
the
cc/batch-flush
branch
from
c9a8491
to
4259658
Compare
camdencheek
force-pushed
the
cc/int8-embeddings-2
branch
from
e9332fd
to
1607c9d
Compare
camdencheek
force-pushed
the
cc/batch-flush
branch
from
4259658
to
051461d
Compare
camdencheek
force-pushed
the
cc/batch-flush
branch
from
051461d
to
bb16846
Compare
jtibshirani
reviewed
Apr 24, 2023
|
|
||
| if len(embeddableChunks) > EMBEDDING_BATCHES*EMBEDDING_BATCH_SIZE { |
There was a problem hiding this comment.
It looks like EMBEDDING_BATCHES is unused now. Was this just an unnecessary complexity that we removed?
There was a problem hiding this comment.
Good catch! I missed that was no longer used.
And yes, it's unnecessary complexity. I'm not sure why, but we were waiting until we had 5 batches worth of embeddings, then sending 1 batch at a time.
jtibshirani
approved these changes
Apr 24, 2023
camdencheek
added a commit
that referenced
this pull request
Apr 27, 2023
This is just some simplification of the batching code so the control flow is more clear. I'm going to be adding stats collection to this function, which will likey muddy things even more, so I wanted to clean this up first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just some simplification of the batching code so the control flow is more clear. I'm going to be adding stats collection to this function, which will likey muddy things even more, so I wanted to clean this up first.
This PR does two things:
addToBatch, which can callflushif adding an embedding hits the batch size limit.Stacked on #50953Test plan
No change of behavior in existing tests covering this function.