Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cody: Add support for more git clone urls and remove reload on codebase update #51274

Merged
merged 2 commits into from
May 2, 2023
Merged

Cody: Add support for more git clone urls and remove reload on codebase update #51274

merged 2 commits into from
May 2, 2023

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Apr 28, 2023 •
edited

Close #51271

  1. Add support for more git clone urls, including @eseliger's alias for github clone URLs (which seems to be a common shorthand format for some codehost) 馃槃
  • see test results below.
  • if codebase is set in config, it should always take precedence over inference.
  1. remove reload requirement on cody.codebase update Cody: remove reloading VS Code requirement when codebase is updated聽#51271

reload

Other minor changes:

  • Update error message style:

Screenshot 2023-04-28 at 10 32 49 AM

- Hide Set access token command , and add Sign in/Sign out to command palette

Test plan

All tests have passed:
image

@cla-bot cla-bot bot added the cla-signed label Apr 28, 2023
@abeatrix abeatrix requested review from a team and eseliger April 28, 2023 17:58
@abeatrix abeatrix self-assigned this Apr 28, 2023
@abeatrix abeatrix added the cody label Apr 28, 2023
@abeatrix abeatrix mentioned this pull request Apr 29, 2023
Closed
philipp-spiess
philipp-spiess approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! Thanks for adding tests too!

eseliger
eseliger approved these changes May 2, 2023
View reviewed changes
client/cody/src/chat/ChatViewProvider.ts Outdated Show resolved Hide resolved
@abeatrix @eseliger
Update client/cody/src/chat/ChatViewProvider.ts
f6f1dca 
Co-authored-by: Erik Seliger <erikseliger@me.com>
@abeatrix abeatrix enabled auto-merge (squash) May 2, 2023 12:27
@abeatrix abeatrix merged commit 306cce6 into main May 2, 2023
7 checks passed
@abeatrix abeatrix deleted the bee/cody-reload branch May 2, 2023 12:34
@abeatrix abeatrix mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

@eseliger eseliger eseliger approved these changes

@thenamankumar thenamankumar thenamankumar approved these changes

Assignees

@abeatrix abeatrix

Labels
cla-signed cody
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cody: remove reloading VS Code requirement when codebase is updated
4 participants
@abeatrix @philipp-spiess @eseliger @thenamankumar