Hide the search results banner if a repo: field is present on sg.com #5142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksnyder
approved these changes
Aug 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #5142 +/- ##
==========================================
+ Coverage 46.22% 46.22% +<.01%
==========================================
Files 734 734
Lines 44992 44994 +2
Branches 2602 2604 +2
==========================================
+ Hits 20796 20797 +1
- Misses 22186 22187 +1
Partials 2010 2010
|
|
It somehow does not appear to work on sourcegraph.com:
|
nicksnyder
reviewed
Aug 9, 2019
| @@ -149,7 +152,7 @@ export const SearchResultsInfoBar: React.FunctionComponent<SearchResultsInfoBarP | |||
| </div> | |||
| </small> | |||
| )} | |||
| {!props.results.alert && props.showDotComMarketing && <ServerBanner />} | |||
| {!props.results.alert && props.showDotComMarketing && !props.hasRepoishField && <ServerBanner />} | |||
There was a problem hiding this comment.
Oops, I didn't review this carefully enough (I was on my phone, sorry). I think it would be better to not hide the banner, but instead change the message (to what it was before) if there is a repo: or repogroup: param (as I described in #5097 (comment)).
@ggilmore, do you know if this was deployed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: manually tested by commenting out
&& props.showDotComMarketinglocally