Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cody: Implemented generate release notes recipes #51481

Merged

Conversation

deepak2431
Copy link
Contributor

This PR is for issue sourcegraph/cody#187.

Test plan

All unit tests and integration tests have passed.
Testing on multiple repos with no tags, tags.
Some of the sample generated output of release notes:

iScreen Shoter - Code - 230504230512 iScreen Shoter - Code - 230504230615

@cla-bot cla-bot bot added the cla-signed label May 4, 2023
@deepak2431 deepak2431 changed the title Cody: Implemented generated release notes recipes Cody: Implemented generate release notes recipes May 4, 2023
@deepak2431
Copy link
Contributor Author

@abeatrix Can you review this please, Thanks in advance!

@abeatrix
Copy link
Contributor

abeatrix commented May 6, 2023

@deepak2431 this is so cool!

Will review first thing next week!

@deepak2431
Copy link
Contributor Author

Sure, Take your time!

Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for Cody too which is cool! Could you add the new change to the CHANGELOG for cody please? @deepak2431

@deepak2431
Copy link
Contributor Author

Thanks for the review @abeatrix. Glad it worked well for Cody too. I have added the changelog.
One thing I would like to mention is that when you enable auto-merge, the PR doesn't get merged; not sure why. So, I think after approval, you need to merge it manually. As PR #51519 is still unmerged.

@abeatrix
Copy link
Contributor

abeatrix commented May 8, 2023

Thanks! There is a conflict with the CHANGELOG. Once the conflict has been resolved I can try to run the pipeline again.

For future references, you can also tag the sourcegraph/cody team as reviewer so anyone on the team can help you with the review and you won't get blocked by me :)

@deepak2431 deepak2431 force-pushed the deepak/cody-recipes-release_notes branch from c26b358 to b4c3317 Compare May 9, 2023 06:38
@deepak2431
Copy link
Contributor Author

Thanks! There is a conflict with the CHANGELOG. Once the conflict has been resolved I can try to run the pipeline again.

For future references, you can also tag the sourcegraph/cody team as reviewer so anyone on the team can help you with the review and you won't get blocked by me :)

I have updated the PR by resolving the conflicts. That will be great, I will keep in mind from the next time to tag sourcegraph/cody team in PR.

@philipp-spiess
Copy link
Contributor

Looking into getting this into todays release, thank you so much for it :)

@philipp-spiess philipp-spiess self-assigned this May 9, 2023
@philipp-spiess philipp-spiess merged commit 1cf391c into sourcegraph:main May 9, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants