deps: revert to golang.org/x/oauth2 upstream #51495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davejrt
approved these changes
May 8, 2023
unknwon
approved these changes
May 8, 2023
pjlast
approved these changes
May 9, 2023
|
https://github.com/golang/oauth2/releases/tag/v0.8.0 was cut yesterday, updated to use that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue this fork was meant to address (golang/oauth2#441) has been fixed upstream:
Notably, both implementations change the error returned to render more verbose details on
.Error()if the response is a status 200 but an error (see above issues)A diff against upstream indicates that there are no other changes: sourcegraph/oauth2#3
This patch is not yet in a full release, but it is the only change on top of the most recent release, so we're not introducing too many unknowns here: golang/oauth2@v0.7.0...cfe200d - when a full release is cut we can upgrade again.https://github.com/golang/oauth2/releases/tag/v0.8.0 was cut yesterday, this PR uses that.Test plan
Test suites pass