Improve / fix arrow keys for Cody history #51586

SuperAuguste · 2023-05-08T18:18:47Z

Some issues that were fixed:

Down arrow did not navigate history forward
You couldn't navigate the WIP prompt with the up arrow as it would navigate history always; now we only navigate to backwards when the up arrow is pressed at the start of the prompt and forwards then the down arrow is pressed at the end of the prompt
There was a typo that prevented the history index from being set properly in VSCode
Input history wasn't populated on the web

Test plan

Tested history navigation in VSCode and web.

sourcegraph-buildkite · 2023-05-08T18:33:08Z

Bundle size report 📦

Initial size	Total size	Async size	Modules
0.00% (0.00 kb)	0.00% (+0.33 kb)	0.00% (+0.33 kb)	0.00% (0)

Look at the Statoscope report for a full comparison between the commits d46f1ab and 0023755 or learn more.

Open explanation

Initial size is the size of the initial bundle (the one that is loaded when you open the page)
Total size is the size of the initial bundle + all the async loaded chunks
Async size is the size of all the async loaded chunks
Modules is the number of modules in the initial bundle

sourcegraph-bot · 2023-05-08T18:33:59Z

📖 Storybook live preview

mrnugget

Approving from VS Code side, but I think @thenamankumar you should look at Web.

client/cody/webviews/Chat.tsx

thenamankumar · 2023-05-09T17:19:05Z

client/web/src/cody/CodyChat.tsx

@@ -74,6 +74,16 @@ export const CodyChat = ({ onClose }: CodyChatProps): JSX.Element => {
        }
    }, [transcript, shouldScrollToBottom, messageInProgress])

+    useEffect(() => {


This seems wrong. transcriptHistory is transcriptJSON[]. It is the list of conversations not a list of chat messages belonging to a single transcript.

I guess what you want to do is:

transcript .filter(message => message.speaker === 'human' && !!message.displayText) .map(({displayText}) => displayText)

I believe my code is the desired behavior as history navigation in VSCode goes through all user inputs for all past conversations, not just the current transcript. (But I'd be happy to switch to the behavior you mentioned if you believe that's the right course of action :))

I haven't experienced it in VS Code yet, will you be able to share a demo video regarding how this will behave on the web when you populate inputHistory with messages from all the previous chats and not just the active chat?

Thanks for asking this Naman, it actually unearthed an odd behavior where only the current chat's messages are populated. I'll look into this.

EDIT: It's because transcriptHistory seems to contain messages like [A, B, C, A, B, C, D, E] where the first C is where I stopped the conversation before reloading the page. Figured it out: there was a incorrectly formatted conversation in there from a long time ago, everything's working great now - I'll send a demo video!

here you go @thenamankumar https://www.loom.com/share/e79c41b3b688486ba42c836d323532a1 :)

This looks good.

client/web/src/cody/CodyChat.tsx

thenamankumar

.

mrnugget · 2023-05-10T10:12:11Z

Heads up: looks like you're getting a TypeScript compiler error

client/cody-web/src/Chat.tsx(71,9): error TS2322: Type '((event: KeyboardEvent<HTMLElement>, caretPosition: number \| null) => void) \| undefined' is not assignable to type 'KeyboardEventHandler<HTMLTextAreaElement> \| undefined'.
--
  | Type '(event: KeyboardEvent<HTMLElement>, caretPosition: number \| null) => void' is not assignable to type 'KeyboardEventHandler<HTMLTextAreaElement>'.

philipp-spiess

Noice! This works very well (tested in VS Code). The old behavior was really buggy and confusing.

Don't forget to add a change log entry :)

client/web/src/cody/components/ChatUI/ChatUi.tsx

client/cody-ui/src/Chat.tsx

mrnugget · 2023-05-16T08:37:58Z

Thanks @SuperAuguste!

Closes #51575. Some issues that were fixed: - Down arrow did not navigate history forward - You couldn't navigate the WIP prompt with the up arrow as it would navigate history always; now we only navigate to backwards when the up arrow is pressed at the start of the prompt and forwards then the down arrow is pressed at the end of the prompt - There was a typo that prevented the history index from being set properly in VSCode - Input history wasn't populated on the web ## Test plan Tested history navigation in VSCode and web.

cla-bot bot added the cla-signed label May 8, 2023

SuperAuguste requested a review from a team May 8, 2023 18:19

SuperAuguste added the cody label May 8, 2023

SuperAuguste force-pushed the auguste/history-arrow-keys branch 3 times, most recently from b395460 to fb1fa81 Compare May 8, 2023 19:17

mrnugget approved these changes May 9, 2023

View reviewed changes

client/cody/webviews/Chat.tsx Outdated Show resolved Hide resolved

thenamankumar reviewed May 9, 2023

View reviewed changes

client/web/src/cody/CodyChat.tsx Outdated Show resolved Hide resolved

thenamankumar requested changes May 9, 2023

View reviewed changes

SuperAuguste added 4 commits May 9, 2023 17:21

Improve and fix history bugs: VSCode

abab983

Improve and fix history bugs: web

dbafe19

Fix lint

a0a429b

Back to just keyDown, improves behavior

cfc87fa

SuperAuguste force-pushed the auguste/history-arrow-keys branch from fb1fa81 to cfc87fa Compare May 9, 2023 21:39

Move callbacks out of tsx

acad154

SuperAuguste requested a review from thenamankumar May 9, 2023 21:52

philipp-spiess approved these changes May 10, 2023

View reviewed changes

client/web/src/cody/components/ChatUI/ChatUi.tsx Outdated Show resolved Hide resolved

client/cody-ui/src/Chat.tsx Outdated Show resolved Hide resolved

SuperAuguste added 3 commits May 10, 2023 14:01

Address feedback

d1bbddb

Merge branch 'main' into auguste/history-arrow-keys

7add241

Edit changelog

d46f1ab

thenamankumar approved these changes May 15, 2023

View reviewed changes

SuperAuguste merged commit 04ff23b into main May 15, 2023
25 of 26 checks passed

SuperAuguste deleted the auguste/history-arrow-keys branch May 15, 2023 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve / fix arrow keys for Cody history #51586

Improve / fix arrow keys for Cody history #51586

SuperAuguste commented May 8, 2023 •

edited

sourcegraph-buildkite commented May 8, 2023 •

edited

sourcegraph-bot commented May 8, 2023 •

edited

mrnugget left a comment

thenamankumar May 9, 2023

SuperAuguste May 9, 2023 •

edited

thenamankumar May 11, 2023

SuperAuguste May 12, 2023 •

edited

SuperAuguste May 12, 2023

thenamankumar May 15, 2023

thenamankumar left a comment

mrnugget commented May 10, 2023

philipp-spiess left a comment

mrnugget commented May 16, 2023

Improve / fix arrow keys for Cody history #51586

Improve / fix arrow keys for Cody history #51586

Conversation

SuperAuguste commented May 8, 2023 • edited

Test plan

sourcegraph-buildkite commented May 8, 2023 • edited

Bundle size report 📦

sourcegraph-bot commented May 8, 2023 • edited

mrnugget left a comment

Choose a reason for hiding this comment

thenamankumar May 9, 2023

Choose a reason for hiding this comment

SuperAuguste May 9, 2023 • edited

Choose a reason for hiding this comment

thenamankumar May 11, 2023

Choose a reason for hiding this comment

SuperAuguste May 12, 2023 • edited

Choose a reason for hiding this comment

SuperAuguste May 12, 2023

Choose a reason for hiding this comment

thenamankumar May 15, 2023

Choose a reason for hiding this comment

thenamankumar left a comment

Choose a reason for hiding this comment

mrnugget commented May 10, 2023

philipp-spiess left a comment

Choose a reason for hiding this comment

mrnugget commented May 16, 2023

SuperAuguste commented May 8, 2023 •

edited

sourcegraph-buildkite commented May 8, 2023 •

edited

sourcegraph-bot commented May 8, 2023 •

edited

SuperAuguste May 9, 2023 •

edited

SuperAuguste May 12, 2023 •

edited