Cody: Recipes PR description #51721
Cody: Recipes PR description #51721
Conversation
deepak2431
force-pushed
the
deepak/recipes-pr_description
branch
from
9334305
to
2abdfcf
Compare
|
@sourcegraph/cody team, requesting a review for this PR. |
|
@mrnugget Made the requested changes. Also, added the changelog. |
|
@deepak2431 can you add a test plan to your PR description? |
|
@mrnugget I have added it. |
…o deepak/recipes-pr_description
|
@mrnugget Can you have a final look at this please? |
|
Looks good, let's go for it |
| @@ -28,6 +28,10 @@ export type RecipeID = | |||
| | 'inline-chat' | |||
| | 'next-questions' | |||
| | 'pr-description' | |||
| | 'non-stop' | |||
There was a problem hiding this comment.
These were alphabetical; let's keep them alphabetized.
There was a problem hiding this comment.
Made the fix @dominiccooney
…o deepak/recipes-pr_description
|
This PR passed Sonarcloud: |
|
@mrnugget For merging PR like this as of external contributions, there's a bit different process, as I know. The "auto-merge" doesn't work. Maybe @abeatrix or @philipp-spiess can help here. |
|
Kicked off a build. Should work now. |
|
@deepak2431 I don't have permission to push to your fork, can you update your fork to fix the Bazel configuration? Ideally you run diff --git a/client/cody-shared/BUILD.bazel b/client/cody-shared/BUILD.bazel
index 3c98c06b57..6cf709008f 100644
--- a/client/cody-shared/BUILD.bazel
+++ b/client/cody-shared/BUILD.bazel
@@ -38,6 +38,7 @@ ts_project(
"src/chat/recipes/find-code-smells.ts",
"src/chat/recipes/fixup.ts",
"src/chat/recipes/generate-docstring.ts",
+ "src/chat/recipes/generate-pr-description.ts",
"src/chat/recipes/generate-release-notes.ts",
"src/chat/recipes/generate-test.ts",
"src/chat/recipes/git-log.ts", |
…o deepak/recipes-pr_description
…k2431/sourcegraph into deepak/recipes-pr_description
|
@mrnugget I have updated the bazel config. I hope it's fixed now. |
This PR is for issue #50526. The idea is to check the templates first with most of the possible locations of the PR template stored. If it exists, use it by summarizing the recent changes of the current checkout branch. Else, just fallback to the summarisation of commits and a checklist at the bottom. Some of the sample PR templates generated:   ## Test plan Tested it manually for different repositories with a PR template. --------- Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
This PR is for issue sourcegraph/cody#183. The idea is to check the templates first with most of the possible locations of the PR template stored. If it exists, use it by summarizing the recent changes of the current checkout branch. Else, just fallback to the summarisation of commits and a checklist at the bottom.
Some of the sample PR templates generated:
Test plan
Tested it manually for different repositories with a PR template.