Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert hallucination detector changes #51785

Merged
merged 2 commits into from
May 11, 2023

Conversation

philipp-spiess
Copy link
Contributor

Fixes #51768

When working on #51576 I was trying to fix some issues where the hallucination detection logic highlighting was not working well and later, based on Rok's input, noticed that this was causing a regression.

The problem? I forgot to push my revert 😭

Screenshot 2023-05-11 at 12 29 47

So here's the revert for the changes in #51576

Test plan

Screenshot 2023-05-11 at 12 31 03

@philipp-spiess philipp-spiess requested a review from a team May 11, 2023 10:33
@philipp-spiess philipp-spiess self-assigned this May 11, 2023
@cla-bot cla-bot bot added the cla-signed label May 11, 2023
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label May 11, 2023
@philipp-spiess philipp-spiess enabled auto-merge (squash) May 11, 2023 10:35
@sourcegraph-bot
Copy link
Contributor

📖 Storybook live preview

@philipp-spiess philipp-spiess merged commit 40477e9 into main May 11, 2023
5 checks passed
@philipp-spiess philipp-spiess deleted the ps/cody-fix-hallucination-issue branch May 11, 2023 10:47
@mrnugget
Copy link
Contributor

forgot to push my revert

that one's new! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/code-exploration Issues owned by the Code Exploration team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cody bug: links to files are escaped after being fully rendered and show up as HTML
4 participants