feature: added new cody receipe optimize #51974

Momilijaz96 · 2023-05-16T06:51:46Z

Test plan

Tested the feature locally by running Cody from "Run and Debug" option of VSCode; with different DSA algorithms in python and general DS/ML based applications and projects. The recipe suggests good code optimizationsto improve memory and time optimizations.

cla-bot · 2023-05-16T06:51:49Z

We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

Sourcegraph teammates should refer to Accepting contributions for guidance.

cla-bot · 2023-05-16T06:53:04Z

We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

Sourcegraph teammates should refer to Accepting contributions for guidance.

Momilijaz96 · 2023-05-16T07:26:11Z

@cla-bot check

cla-bot · 2023-05-16T07:26:14Z

The GitHub CLA Bot is rechecking to see that you have signed the CLA - note that it may take up to 30 minutes for your response to be synchronized.

Momilijaz96 · 2023-05-18T05:21:07Z

@cla-bot check

cla-bot · 2023-05-18T05:21:10Z

The GitHub CLA Bot is rechecking to see that you have signed the CLA - note that it may take up to 30 minutes for your response to be synchronized.

mrnugget

Thanks for the PR, @Momilijaz96! Very interesting. Do you have examples of how it worked? Did you test it on some code and got good results?

There's some linting issues, according to CI:



> @ format:check /root/buildkite/build/sourcegraph
--
  | > prettier '**/{*.{js?(on),ts?(x),graphql,md,scss},.*.js?(on)}' --config prettier.config.js --check --write=false
  |  
  | Checking formatting...
  | [warn] client/cody-shared/src/chat/recipes/vscode-recipes.ts
  | [warn] client/cody/src/main.ts
  | [warn] Code style issues found in 2 files. Forgot to run Prettier?

Those need to be fixed

mrnugget · 2023-05-19T09:42:52Z

client/cody-shared/src/chat/recipes/vscode-recipes.ts

        new GenerateDocstring(),
        new GenerateTest(),
        new GitHistory(),
        new ImproveVariableNames(),
+        new InlineChat(),


Why the reorder?

I removed the reordering, I guess that was extra.

philipp-spiess

This is really interesting. I feel like we should have a recipe regarding time and space complexity!! Thank you so much for this.

I would also love to see some examples as @mrnugget suggested

client/cody-shared/src/chat/recipes/optimize-code.ts

Momilijaz96 · 2023-05-22T10:19:20Z

Thanks for the PR, @Momilijaz96! Very interesting. Do you have examples of how it worked? Did you test it on some code and got good results?

There's some linting issues, according to CI:
> @ format:check /root/buildkite/build/sourcegraph
--
  | > prettier '**/{*.{js?(on),ts?(x),graphql,md,scss},.*.js?(on)}' --config prettier.config.js --check --write=false
  |  
  | Checking formatting...
  | [warn] client/cody-shared/src/chat/recipes/vscode-recipes.ts
  | [warn] client/cody/src/main.ts
  | [warn] Code style issues found in 2 files. Forgot to run Prettier?
Those need to be fixed

I installed prettier and ran it manually by prettier --write <file-name> for both pointed out files to fix it the formatting.

Co-authored-by: Philipp Spiess <hello@philippspiess.com>

Momilijaz96 · 2023-05-22T15:23:37Z

This is really interesting. I feel like we should have a recipe regarding time and space complexity!! Thank you so much for this.

I would also love to see some examples as @mrnugget suggested

Sure thing!
So I tested it on a couple different codes:
a. Some python data structures and algorithms code [Tree data structure + dynamic programming problems] - Result: Suggest optimization if possible.
b. Yaml and Json files [Docker image and kuberentes manifest files] - Result: No optimization should be suggested
c. Model's predict function -Result: Depends on implementation.
I have attached the result snaps, of the local run here:

Momilijaz96 · 2023-05-22T15:27:30Z

Overall the models suggest good optimizations for the code but
there are few cases that I could'nt handle, even with iterative prompt development:
a. I could'nt fix the format of the output, I wanted the "optimization steps", "time/space consumption improvement" in text and "updated code block" in a code block, but no changes in the prompt helped me achieve that.
b. I also struggled with the input code not be included in response, but it is included sometimes with current prompt.
c. I tested it on limited file formats and code types.
Let me know what you guys think!
I

mrnugget · 2023-05-23T09:44:31Z

Looking at the examples here (#51974 (comment)) it seems like the formatting is broken, no? Every reply is prefixed with "Here is the response" and then it's raw Markdown.

That should be fixed before we merge this

mrnugget

See my comment inline and the previous comment further up

mrnugget · 2023-05-23T09:45:42Z

client/cody-shared/src/chat/recipes/optimize-code.ts

+Don't include the input code in your response. Beautify the response for better readability.\
+Response format should be: This code can/cannot be optimzed. Optimization Steps: {} Time and Space Usage: {} Updated Code: {}\
+However if no optimization is possible; just say the code is already optimized. \n\n\`\`\`${extension}\n${truncatedSelectedText}\n\`\`\`\n${MARKDOWN_FORMAT_PROMPT}`
+        const assistantResponsePrefix = `Here is the response  \n\`\`\`${extension}\n`


I think this breaks the formatting: we don't want every response prefixed with "Here is the response"

Thanks for pointing that out... removing the response prefix, fixed the response format.
Check out these examples now:

philipp-spiess · 2023-05-23T15:58:11Z

🎉

@Momilijaz96 do you mind solving the merge conflict? I can look into it as well if you're busy. Ping me here when you did this so I can run the latest changes on CI and we can ship this 🚀

Momilijaz96 · 2023-05-24T07:06:38Z

🎉

@Momilijaz96 do you mind solving the merge conflict? I can look into it as well if you're busy. Ping me here when you did this so I can run the latest changes on CI and we can ship this 🚀

Hey @philipp-spiess I don't have the write access to resolve the conflict.

philipp-spiess · 2023-05-24T08:04:05Z

@Momilijaz96 You should be able to update your forked repository. Try something like this in the terminal. If that doesn't work, I can look into it :)

git remote -v # This should list your fork as the `origin` for this to work. 
git fetch
git merge origin/main

Momilijaz96 · 2023-05-24T09:14:36Z

@Momilijaz96 You should be able to update your forked repository. Try something like this in the terminal. If that doesn't work, I can look into it :)
git remote -v # This should list your fork as the `origin` for this to work. 
git fetch
git merge origin/main

Alright, i guess it's ready to be merged.

philipp-spiess · 2023-05-24T09:19:20Z

client/cody-shared/src/chat/recipes/vscode-recipes.ts

@@ -0,0 +1,60 @@
+import { ChatQuestion } from './chat-question'


Huh there seems to be a conflict here, this file was moved into the client/cody folder on main

I accidently merged current branch into main, I "undo" it and pushed again, I guess that would resolve this conflict.

I think linting is failing on some files too, I can't see which ones though.

This file still seems to be added instead. Is it okay if I push onto your branch to try and resolve this??

yeah sure, go ahead

Apparently my forked repo's main branch is a few commits ahead of the upstream's main. I am trying to fetch upstream and merge into my fork's main, but that is not introducing any changes.

Momilijaz96 · 2023-05-25T09:15:15Z

Hey @philipp-spiess , Thanks for taking care of this. 👍
Is the conflict resolved now? or something else needs be done from my end.

philipp-spiess · 2023-05-25T09:24:53Z

@Momilijaz96 All done from your end 🎉 I’m just working on getting CI to pass before I can merge this 🙂

philipp-spiess · 2023-05-25T10:40:57Z

@Momilijaz96 There appears to be a bug in our CI setup right now, I've asked internally for some advice. I'll have this PR bookmarked though and will continue to look into it 🙇

Momilijaz96 · 2023-05-25T11:02:05Z

@Momilijaz96 There appears to be a bug in our CI setup right now, I've asked internally for some advice. I'll have this PR bookmarked though and will continue to look into it 🙇

No worries, Sounds good.

philipp-spiess · 2023-05-26T16:50:32Z

Y'all we did it! 🎉 @Momilijaz96 @mrnugget

Momilijaz96 · 2023-05-26T19:18:03Z

Y'all we did it! 🎉 @Momilijaz96 @mrnugget

Great 💯

jdorfman · 2023-05-29T14:48:41Z

This is a fantastic addition, great work @Momilijaz96!

And thank you @mrnugget @philipp-spiess for reviewing it.

## Test plan Tested the feature locally by running Cody from "Run and Debug" option of VSCode; with different DSA algorithms in python and general DS/ML based applications and projects. The recipe suggests good code optimizationsto improve memory and time optimizations. --------- Co-authored-by: Philipp Spiess <hello@philippspiess.com>

feature: added new cody receipe optimize

6f21aff

Merge branch 'main' into momal-new-cody-recepie

51e0314

cla-bot bot added the cla-signed label May 16, 2023

Merge branch 'main' into momal-new-cody-recepie

86a9e4c

mrnugget requested a review from a team May 19, 2023 08:17

mrnugget suggested changes May 19, 2023

View reviewed changes

philipp-spiess reviewed May 19, 2023

View reviewed changes

client/cody-shared/src/chat/recipes/optimize-code.ts Outdated Show resolved Hide resolved

fix: removed the extra reordering + Added prettier formatting to 2 files

4315e28

Momilijaz96 and others added 2 commits May 22, 2023 16:45

Update client/cody-shared/src/chat/recipes/optimize-code.ts

35d8661

Co-authored-by: Philipp Spiess <hello@philippspiess.com>

fix: updated prompt + Added recipe to receipe.ts

7ada087

Momilijaz96 requested review from philipp-spiess and mrnugget May 22, 2023 15:29

thenamankumar approved these changes May 22, 2023

View reviewed changes

thenamankumar self-requested a review May 22, 2023 21:51

mrnugget suggested changes May 23, 2023

View reviewed changes

fix: updated prompt and fixed response format

c7b04e1

mrnugget approved these changes May 23, 2023

View reviewed changes

Merge remote-tracking branch 'origin/main' into momal-new-cody-recepie

77ed88a

philipp-spiess reviewed May 24, 2023

View reviewed changes

Momilijaz96 requested a review from philipp-spiess May 25, 2023 07:35

philipp-spiess added 2 commits May 25, 2023 10:50

Merge remote-tracking branch 'origin/main' into momal-new-cody-recepie

30e0add

Apply changes to main

bee7ae0

philipp-spiess added 2 commits May 26, 2023 14:56

Fix bazel

453d9db

Add changelog

a1efc59

philipp-spiess merged commit cf26cdc into sourcegraph:main May 26, 2023
5 of 6 checks passed

Momilijaz96 deleted the momal-new-cody-recepie branch May 26, 2023 19:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: added new cody receipe optimize #51974

feature: added new cody receipe optimize #51974

Momilijaz96 commented May 16, 2023

cla-bot bot commented May 16, 2023

cla-bot bot commented May 16, 2023

Momilijaz96 commented May 16, 2023

cla-bot bot commented May 16, 2023

Momilijaz96 commented May 18, 2023

cla-bot bot commented May 18, 2023

mrnugget left a comment

mrnugget May 19, 2023

Momilijaz96 May 22, 2023

philipp-spiess left a comment •

edited

Loading

Momilijaz96 commented May 22, 2023

Momilijaz96 commented May 22, 2023

Momilijaz96 commented May 22, 2023 •

edited

Loading

mrnugget commented May 23, 2023

mrnugget left a comment

mrnugget May 23, 2023

Momilijaz96 May 23, 2023 •

edited

Loading

philipp-spiess commented May 23, 2023

Momilijaz96 commented May 24, 2023

philipp-spiess commented May 24, 2023

Momilijaz96 commented May 24, 2023

philipp-spiess May 24, 2023

Momilijaz96 May 24, 2023

Momilijaz96 May 24, 2023

philipp-spiess May 24, 2023

Momilijaz96 May 24, 2023

Momilijaz96 May 24, 2023

Momilijaz96 commented May 25, 2023

philipp-spiess commented May 25, 2023

philipp-spiess commented May 25, 2023

Momilijaz96 commented May 25, 2023

philipp-spiess commented May 26, 2023

Momilijaz96 commented May 26, 2023 •

edited

Loading

jdorfman commented May 29, 2023

		@@ -0,0 +1,60 @@
		import { ChatQuestion } from './chat-question'

feature: added new cody receipe optimize #51974

feature: added new cody receipe optimize #51974

Conversation

Momilijaz96 commented May 16, 2023

Test plan

cla-bot bot commented May 16, 2023

cla-bot bot commented May 16, 2023

Momilijaz96 commented May 16, 2023

cla-bot bot commented May 16, 2023

Momilijaz96 commented May 18, 2023

cla-bot bot commented May 18, 2023

mrnugget left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

philipp-spiess left a comment • edited Loading

Choose a reason for hiding this comment

Momilijaz96 commented May 22, 2023

Momilijaz96 commented May 22, 2023

Momilijaz96 commented May 22, 2023 • edited Loading

mrnugget commented May 23, 2023

mrnugget left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Momilijaz96 May 23, 2023 • edited Loading

Choose a reason for hiding this comment

philipp-spiess commented May 23, 2023

Momilijaz96 commented May 24, 2023

philipp-spiess commented May 24, 2023

Momilijaz96 commented May 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Momilijaz96 commented May 25, 2023

philipp-spiess commented May 25, 2023

philipp-spiess commented May 25, 2023

Momilijaz96 commented May 25, 2023

philipp-spiess commented May 26, 2023

Momilijaz96 commented May 26, 2023 • edited Loading

jdorfman commented May 29, 2023

philipp-spiess left a comment •

edited

Loading

Momilijaz96 commented May 22, 2023 •

edited

Loading

Momilijaz96 May 23, 2023 •

edited

Loading

Momilijaz96 commented May 26, 2023 •

edited

Loading