Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cody: Fix useContext none setting and add type for winkJS #52126

Merged
merged 4 commits into from
May 18, 2023

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented May 18, 2023

Close: #52125

This PR includes a fix to #52125 where setting cody.useContext to none works the same as setting it to blend or embeddings.

Also add types for WinkJS and data returned by ripgrep to get rid of the eslint errors that have been bothering me 馃槄
image
image

Test plan

Set cody.useContext to none to confirm no context is included for Cody except the currently opened file:
image

@cla-bot cla-bot bot added the cla-signed label May 18, 2023
@sourcegraph-buildkite
Copy link
Collaborator

sourcegraph-buildkite commented May 18, 2023

Bundle size report 馃摝

Initial size Total size Async size Modules
0.00% (0.00 kb) -0.00% (-0.04 kb) -0.00% (-0.04 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits e5ef769 and 97910a6 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@abeatrix abeatrix marked this pull request as ready for review May 18, 2023 15:45
@abeatrix abeatrix requested review from a team May 18, 2023 15:45
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented May 18, 2023

馃摉 Storybook live preview

Copy link
Member

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@abeatrix abeatrix enabled auto-merge (squash) May 18, 2023 17:23
@abeatrix abeatrix merged commit 2c8d150 into main May 18, 2023
10 of 12 checks passed
@abeatrix abeatrix deleted the bee/cody-papercuts branch May 18, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cody Bug: Setting useContext to 'none' uses embeddings
4 participants