Cody: Update menu icons and order #52263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeatrix
commented
May 22, 2023
| @@ -1,6 +1,18 @@ | |||
| import { convertGitCloneURLToCodebaseName } from './ChatViewProvider' | |||
|
|
|||
| describe('convertGitCloneURLToCodebaseName', () => { | |||
| // before each test, mock the createOutputChannel function from vscode with globalThis | |||
| beforeEach(() => { | |||
There was a problem hiding this comment.
Getting the same error Test suite failed to run TypeError: Cannot read properties of undefined (reading 'createOutputChannel') when I tried
beforeEach(() => {
jest.resetModules()
jest.mock('vscode', () => ({
window: {
createOutputChannel: () => ({
appendLine: () => {},
}),
},
}))
})There was a problem hiding this comment.
OH you know why, it's because the import happens before we do the mock already 🙃
There's a way in jest to fix this, let me look it up
abeatrix
commented
May 22, 2023
| @@ -1,6 +1,18 @@ | |||
| import { convertGitCloneURLToCodebaseName } from './ChatViewProvider' | |||
|
|
|||
| describe('convertGitCloneURLToCodebaseName', () => { | |||
| // before each test, mock the createOutputChannel function from vscode with globalThis | |||
| beforeEach(() => { | |||
There was a problem hiding this comment.
Getting the same error Test suite failed to run TypeError: Cannot read properties of undefined (reading 'createOutputChannel') when I tried
beforeEach(() => {
jest.resetModules()
jest.mock('vscode', () => ({
window: {
createOutputChannel: () => ({
appendLine: () => {},
}),
},
}))
})or
globalThis.vscode = {
createOutputChannel: () => {}
} as any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update title menu icon to align with Tim's design (figma) and web design:
Tim's Design:
Web:
Before:
After:
Other minor clean up for the package.json
"cody.customHeaders"to the order list item number 4 and moved all the experimental features after it for clarity.guardrailssince it was missingTest plan
See screenshots