Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cody: Pretty much redesign everything #52284

Closed
wants to merge 7 commits into from
Closed

Conversation

SuperAuguste
Copy link
Contributor

@SuperAuguste SuperAuguste commented May 22, 2023

I applied most of @toolmantim's awesome Cody design ideas to the chat window with some additional things:

  • I didn't get rid of the "Cody" and "Me" labels to reduce potential confusion from users + we need the edit button/feedback buttons to be displayed somewhere, and without the sender names they just look all sad and lonely :(
  • I got rid of the <Header />; I love the Cody logo so much, it's equal parts cute and creepy, but it's also weird in color on dark themes and it consumes lots of much needed space, so I removed it. In my mind, we already convey that this is Sourcegraph Cody from the logo in the far-left sidebar, the name at the top, and the gray logo (which looks amazing everywhere 💅) in chat messages from Cody
  • I added a chat view navigation command and icon as we need it now that we have no navbar - optimally we'll split everything out into more resizable panes later (or right now, I'm down to do this all in this PR, but I wanted to do this in chunks), but this is the best solution right now imo (except maybe adding a back button on all non-chat views, you decide :P)

Btw I have more things I want to address later, but I want to start off simpler first :)

Before

Screenshot 2023-05-22 at 4 42 49 PM

After

Screenshot 2023-05-22 at 4 43 17 PM

Test plan

Tested in VSCode and web and it looks good.

@cla-bot cla-bot bot added the cla-signed label May 22, 2023
@SuperAuguste SuperAuguste requested review from a team and toolmantim May 22, 2023 20:45
@sourcegraph-buildkite
Copy link
Collaborator

sourcegraph-buildkite commented May 22, 2023

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.70 kb) 0.01% (+0.70 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 9a237a8 and 0e96f9d or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented May 22, 2023

📖 Storybook live preview

@toolmantim
Copy link
Contributor

Oh wow, it's super cool to see this come to life! And I like some of your changes! I'm going to check this out locally and give it all a try 👏🏼 Some of these ideas I was just in gathering feedback stage, but getting the chance to full test them out is even better. I really want to help move recipes forward into something great… this could be the start of that.

I think we'll need to keep this in draft for now? And then either cherry-pick bits alongside the work I'm doing with @abeatrix & @dominiccooney, or just troop forward with more changes on this branch and land this first. I'll check back and let you know.

@toolmantim
Copy link
Contributor

@SuperAuguste thanks for hanging in while I figured out the design direction here. Let's put the recipe pane idea aside for the moment, and keep the tab bar for now.

I'd love to see these message style changes go live tho! Would it be possible to PR just that part of the change?

@SuperAuguste
Copy link
Contributor Author

Sorry I couldn't allocate time for this, happy to see parts of it being integrated in #53332! :)

@SuperAuguste SuperAuguste deleted the auguste/cody-tim-design branch June 12, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants