Cody: Fix Inline Assist decorations #52322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseliger
approved these changes
May 23, 2023
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
Close: #52320 We are resetting the task ID when Cody replies before the replacement task is run, which led to the fixup replacement task unable to locate the Code Lens which handles the decorations using the task ID. Solution: The task ID should only need to be reset after the fixup task has been completed, as it is only set when a fix up task is run. ## Test plan <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> Tested locally: <img width="1482" alt="image" src="https://github.com/sourcegraph/sourcegraph/assets/68532117/78f18a64-83d1-4143-92d7-5c924dddaa18"> <img width="1438" alt="image" src="https://github.com/sourcegraph/sourcegraph/assets/68532117/140b311b-dc76-4413-afb2-7887a4007e96"> The fix also pass the WIP e2e test in #52337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #52320
We are resetting the task ID when Cody replies before the replacement task is run, which led to the fixup replacement task unable to locate the Code Lens which handles the decorations using the task ID.
Solution: The task ID should only need to be reset after the fixup task has been completed, as it is only set when a fix up task is run.
Test plan
Tested locally:
The fix also pass the WIP e2e test in #52337