Cody: Update to log errors from embeddings #52780
Conversation
| @@ -375,13 +374,7 @@ export class ChatViewProvider implements vscode.WebviewViewProvider, vscode.Disp | |||
| this.sendTranscript() | |||
| void this.saveTranscriptToChatHistory() | |||
| void vscode.commands.executeCommand('setContext', 'cody.reply.pending', false) | |||
| if (!this.codebaseContext.checkEmbeddingsConnection()) { | |||
There was a problem hiding this comment.
We don't need this check because this is the same function we used to display the NOT INDEXED and INDEXED status in the Chat UI
|
Do we show any indication to a user that something went wrong? Even just a little yellow exclamation point or something would be great. I'm concerned this will cause more users to get worse context with no way of knowing, and then they'll never reach out for support because they don't know something is wrong (they just think Cody is bad instead) |
@camdencheek That's a good point. So on top of the connection status we are currently displaying as |
|
Sounds good to me! As long as there is some indication of an error, I'm happy |
|
@camdencheek can I have your review, please 🙇♀️ |
Close #52696
RE https://sourcegraph.slack.com/archives/C04MSD3DP5L/p1685629520228399?thread_ts=1685626165.446539&cid=C04MSD3DP5L
Currently the error messages from the embedding services are being displayed in the UI, which can be disruptive to users using keyword contexts. We will log the errors in debug output instead.
Updated: on top of the connection status we are currently displaying as INDEXED and NON-INDEXED under chat box, I've updated the function to display search errors for users who are currently using 'embeddings', is connected to a indexed codebase, but getting search errors from the embeddings service.
Test plan
We can see the embeddings service error in our current test build since we don't have the embedding service mocked:
Added a test step to confirm the error message is not showing up in UI anymore