Cody: Open files in workspace #53069
Conversation
There was a problem hiding this comment.
We have an issue where sometimes paths are detected inside single backtick inline code blocks which means that it will escape the HTML tag which renders oddly.
Basically like this `foo <span blabla>bar/quz</span>`
I am worried that adding more HTML will make this experience worse. On the other hand, it works for 80% of the cases and there, not being able to click it is really bad, so let's go ahead with it.
|
Does this make #52029 redundant? There's been some design improvements on there… |
Oh that's a good thing to know. I will keep this in mind and yea let's go ahead with this and get more feedback before we decide how to improve this! Thanks for the review! |
I didn't change anything regarding the styles so it'd be nice to have your changes too! The style for the hallucinated path in your PR looks so cute :D |
Close #52863
Loom: https://www.loom.com/share/62c920c3c2e94d67b2f6266689a2e4fc
Open validated file paths from Cody's response as workspace file, excluding directories (opening a path to directory would create a new workspace for the directory).
Test plan
Locally tested. All tests have passed. See video:
Cody_.Open.non-hallucinated.file.paths.in.workspace.mp4