Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cody tests by hardcoding VS Code version #53224

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

philipp-spiess
Copy link
Contributor

As of the latest VS Code update, we see our extension test not working properly across both the integration and E2E setups. This seems to be an upstream problem and was also reported here: microsoft/vscode-test#221

This PR hardcodes these setups to use the previous version.

Test plan

  • CI passes again

@philipp-spiess philipp-spiess requested review from a team June 9, 2023 10:44
@philipp-spiess philipp-spiess self-assigned this Jun 9, 2023
@cla-bot cla-bot bot added the cla-signed label Jun 9, 2023
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label Jun 9, 2023
@sourcegraph-bot
Copy link
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff f4607dc...38b6e2d.

Notify File(s)
@bobheadxi enterprise/dev/ci/internal/ci/operations.go

@sourcegraph-bot
Copy link
Contributor

Codenotify: Notifying subscribers in OWNERS files for diff f4607dc...38b6e2d.

Notify File(s)
@sourcegraph/dev-experience enterprise/dev/ci/internal/ci/operations.go

@sourcegraph-bot
Copy link
Contributor

📖 Storybook live preview

@philipp-spiess philipp-spiess merged commit 5589c8f into main Jun 9, 2023
19 of 20 checks passed
@philipp-spiess philipp-spiess deleted the ps/cody-test-vsce-version branch June 9, 2023 10:58
ErikaRS pushed a commit that referenced this pull request Jun 22, 2023
As of the latest VS Code update, we see our extension test not working
properly across both the integration and E2E setups. This seems to be an
upstream problem and was also reported here:
microsoft/vscode-test#221

This PR hardcodes these setups to use the previous version.
 
## Test plan

- CI passes again

<!-- All pull requests REQUIRE a test plan:
https://docs.sourcegraph.com/dev/background-information/testing_principles
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/code-exploration Issues owned by the Code Exploration team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants