Completions: Fix issue where completion sometimes starts in a new line #53246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team/code-exploration
|
This one is actually quite noticeable since we prefer responses with more lines of code now, so let's get this out quickly. |
eseliger
approved these changes
Jun 9, 2023
abeatrix
approved these changes
Jun 10, 2023
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
#53246) I noticed a small issue when completions are triggered for non-empty lines. We have one of the three requests that injects a `\n` at the end of the prefix. This was added back _after_ the trimming logic which of course means that it would include the `\n` in the result, not something that we want. We have to evaluate and see if this logic really makes sense. For now it's just a way to "trigger" a response. ## Test plan - Tested this locally <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
sqs
pushed a commit
to sourcegraph/cody
that referenced
this pull request
Jul 10, 2023
sourcegraph/sourcegraph#53246) I noticed a small issue when completions are triggered for non-empty lines. We have one of the three requests that injects a `\n` at the end of the prefix. This was added back _after_ the trimming logic which of course means that it would include the `\n` in the result, not something that we want. We have to evaluate and see if this logic really makes sense. For now it's just a way to "trigger" a response. ## Test plan - Tested this locally <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a small issue when completions are triggered for non-empty lines.
We have one of the three requests that injects a
\nat the end of the prefix. This was added back after the trimming logic which of course means that it would include the\nin the result, not something that we want.We have to evaluate and see if this logic really makes sense. For now it's just a way to "trigger" a response.
Test plan