Cody: Add status bar item #53307

philipp-spiess · 2023-06-12T13:35:06Z

This PR adds a new status bar item for Cody that we can use as a global loading indicator (helpful for completions) and an easy way to enable/disable features. More features coming soon!

As a follow-up we should make sure that all of these three features can be turned on/off without having to reload the editor cc @abeatrix @lrhacker

Test plan

Screen.Recording.2023-06-12.at.17.01.03.mov

…ode extension)

umpox

Nice!

client/cody/CHANGELOG.md

client/cody/src/status-bar.ts

Co-authored-by: Tom Ross <tomross8@googlemail.com>

abeatrix

Update:Resolved. I had cody.suggestions enabled instead of cody.completions

Is there anything I'll need to change to get the cody icon to show up in my status bar?

client/cody/src/status-bar.ts

client/cody/src/main.ts

client/cody/src/status-bar.ts

Co-authored-by: Beatrix <68532117+abeatrix@users.noreply.github.com>

client/cody/src/status-bar.ts

Co-authored-by: Beatrix <68532117+abeatrix@users.noreply.github.com>

Co-authored-by: Tom Ross <tomross8@googlemail.com>

client/cody/src/status-bar.ts

toolmantim · 2023-06-13T12:02:02Z

Toggling completions on and off doesn't seem to work for me…

Screen.Recording.2023-06-13.at.9.58.04.pm.mov

philipp-spiess · 2023-06-13T12:03:32Z

@toolmantim You have to reload afterwards. I have a follow-up ticket to make it automatically reload. Will add @umpox's suggestion of a reload button for now

philipp-spiess · 2023-06-13T12:05:35Z

@toolmantim Also it's unlikely it will work as expected in your case -- You won't see any of these features from this view 😬 .

We only load new chat suggestions unless you send a new message
You don't have code open to see completions or inline assist

toolmantim · 2023-06-13T12:39:04Z

Alright, I've just pushed up some design improvements…

The labels were taken from the package.json — they need some improvement, but that can come later.

The icon looks a little thin still… but the font lives! I'll increase the line weight of the icon a bit.

toolmantim · 2023-06-13T12:44:36Z

You have to reload afterwards. I have a follow-up ticket to make it automatically reload. Will add @umpox's suggestion of a reload button for now

@philipp-spiess oh, I wasn't even talking about using the feature… more just that it doesn't seem to be affecting the actual underlying setting at all:

Screen.Recording.2023-06-13.at.10.40.44.pm.mov

…egraph into ps/cody-statusbar-item

philipp-spiess · 2023-06-13T13:06:12Z

@toolmantim I can not reproduce this but I also noticed I have uncommitted changes 😶‍🌫️ Maybe that's why it works for me?

Screen.Recording.2023-06-13.at.15.04.28.mov

toolmantim · 2023-06-13T13:38:33Z

@philipp-spiess has the setting been renamed? Perhaps we need to smooth migrate people across to the new setting, if it causes this bug? It would be fine to have it just reset, given it was experimental… but probably not stop you from turning it on…

Here's my Cody-related user settings JSON:

{
  "cody.experimental.chatPredictions": false,
  "cody.experimental.suggestions": true,
  "cody.experimental.inline": false,
  "cody.experimental.nonStop": true,
  "cody.debug.enable": true,
  "cody.debug.verbose": true,
  "cody.completions": false
}

toolmantim · 2023-06-13T13:39:13Z

Alright! Chunkier logo is in 🏴‍☠️

philipp-spiess · 2023-06-13T13:50:33Z

@philipp-spiess has the setting been renamed? Perhaps we need to smooth migrate people across to the new setting, if it causes this bug? It would be fine to have it just reset, given it was experimental… but probably not stop you from turning it on…

Hmm yeah that's probably it. It tried to be smart about it and enable completions when the deprecated flag value is set but I haven't considered the UI to change settings so now it will show as disabled in the UI even when it's enabled 🙃 I think we'll need to run a migration script on startup or so instead. I'll revert the change on main (Since we aren't 100% sure on the name yet + I want to push a bugfix release) and will follow up with the fixes.

Glad you found this 😬

This reverts commit d007c1c. Two reasons: - We found some bugs with the migration in #53307 - We want to make a bug fix release now and aren't settled on the name 100% yet (so I want to reduce churn) ## Test plan - 👀

philipp-spiess · 2023-06-14T09:47:23Z

@toolmantim Here's a final video. This looks so good now 😍

Screen.Recording.2023-06-14.at.11.45.47.mov

philipp-spiess · 2023-06-14T10:07:03Z

client/cody/src/services/FeedbackOptions.ts

+export const FeedbackOptions = [
+    {
+        label: '$(feedback) Feedback',
+        detail: 'Have an idea, found a bug, or need help? Let us know.',
+        async onSelect(): Promise<void> {
+            await vscode.env.openExternal(
+                vscode.Uri.parse(
+                    'https://github.com/sourcegraph/sourcegraph/discussions/new?category=product-feedback&labels=cody,cody/vscode'
+                )
+            )
+        },
+    },
+    {
+        label: '$(remote-explorer-documentation) Documentation',
+        detail: 'Search the Cody documentation.',
+        async onSelect(): Promise<void> {
+            await vscode.env.openExternal(vscode.Uri.parse('https://docs.sourcegraph.com/cody'))
+        },
+    },
+    {
+        label: '$(organization) Discord Channel',
+        detail: 'Join our Discord community’s #cody channel.',
+        async onSelect(): Promise<void> {
+            await vscode.env.openExternal(vscode.Uri.parse('https://discord.gg/s2qDtYGnAE'))
+        },
+    },
+]


cc @abeatrix this is the shared stuff as that I mentioned in the Figma :)

Oh I've already added it to my PR yesterday, but if yours land first i can remove mine and merge yours 👌 #53434

@abeatrix Already landed mine 😬

sourcegraph-bot · 2023-06-14T10:10:19Z

📖 Storybook live preview

This reverts commit d007c1c. Two reasons: - We found some bugs with the migration in #53307 - We want to make a bug fix release now and aren't settled on the name 100% yet (so I want to reduce churn) ## Test plan - 👀

@abeatrix

Closes #52597 This PR adds a new status bar item for Cody that we can use as a global loading indicator (helpful for completions) and an easy way to enable/disable features. More features coming soon! As a follow-up we should make sure that all of these three features can be turned on/off without having to reload the editor cc @abeatrix @lrhacker ## Test plan https://github.com/sourcegraph/sourcegraph/assets/458591/ab2b5a5e-6b38-4010-92f1-1796ef0a3c10  --------- Co-authored-by: Tom Ross <tomross8@googlemail.com> Co-authored-by: Beatrix <68532117+abeatrix@users.noreply.github.com> Co-authored-by: Tim Lucas <t@toolmantim.com>

philipp-spiess added 2 commits June 12, 2023 13:34

Move cody icons into clients folder (so we can refernece it from VS C…

bc65558

…ode extension)

Cody: Add status bar item, loading behavior logic, and actions

d2e90a8

cla-bot bot added the cla-signed label Jun 12, 2023

github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label Jun 12, 2023

philipp-spiess added 2 commits June 12, 2023 17:02

Implement quick pick

f371b93

Add changelog entry

5210dc5

philipp-spiess requested review from valerybugakov, dominiccooney, abeatrix and a team June 12, 2023 15:04

philipp-spiess self-assigned this Jun 12, 2023

philipp-spiess requested review from toolmantim and umpox June 12, 2023 15:05

philipp-spiess marked this pull request as ready for review June 12, 2023 15:05

philipp-spiess requested a review from lrhacker June 12, 2023 15:06

umpox approved these changes Jun 12, 2023

View reviewed changes

client/cody/CHANGELOG.md Outdated Show resolved Hide resolved

client/cody/src/status-bar.ts Outdated Show resolved Hide resolved

client/cody/src/status-bar.ts Outdated Show resolved Hide resolved

Update client/cody/CHANGELOG.md

e4860bb

Co-authored-by: Tom Ross <tomross8@googlemail.com>

abeatrix reviewed Jun 12, 2023

View reviewed changes

client/cody/src/status-bar.ts Outdated Show resolved Hide resolved

abeatrix requested changes Jun 12, 2023

View reviewed changes

client/cody/src/status-bar.ts Outdated Show resolved Hide resolved

client/cody/src/main.ts Outdated Show resolved Hide resolved

client/cody/src/status-bar.ts Outdated Show resolved Hide resolved

Update client/cody/src/status-bar.ts

a76fed6

Co-authored-by: Beatrix <68532117+abeatrix@users.noreply.github.com>

abeatrix mentioned this pull request Jun 12, 2023

cody: toggle config for inline and non-stop no reload required #53348

Merged

Fixes

f8de0af

philipp-spiess requested a review from abeatrix June 13, 2023 09:20

abeatrix approved these changes Jun 13, 2023

View reviewed changes

client/cody/src/status-bar.ts Outdated Show resolved Hide resolved

philipp-spiess and others added 2 commits June 13, 2023 12:51

Update client/cody/src/status-bar.ts

6af12fc

Co-authored-by: Beatrix <68532117+abeatrix@users.noreply.github.com>

Update client/cody/src/status-bar.ts

2b0d392

Co-authored-by: Tom Ross <tomross8@googlemail.com>

valerybugakov approved these changes Jun 13, 2023

View reviewed changes

client/cody/src/status-bar.ts Outdated Show resolved Hide resolved

Add some labels, icons and separator labels

b0a8ca4

Merge branch 'ps/cody-statusbar-item' of github.com:sourcegraph/sourc…

680cffd

…egraph into ps/cody-statusbar-item

philipp-spiess and others added 3 commits June 13, 2023 15:06

Merge remote-tracking branch 'origin/main' into ps/cody-statusbar-item

b01884b

Fix changelog

73b55bb

Make my logo bigger. Give it more pop!

8f8de79

toolmantim approved these changes Jun 13, 2023

View reviewed changes

philipp-spiess mentioned this pull request Jun 13, 2023

Revert "Completions: Rename config option (#53240)" #53392

Merged

philipp-spiess added 2 commits June 14, 2023 11:35

Merge remote-tracking branch 'origin/main' into ps/cody-statusbar-item

2529b4c

Rebase and final updates

97040f8

philipp-spiess added 4 commits June 14, 2023 11:47

Add bazel thingy

1d61dc9

Add bazel config to fonts package

8df0fd1

I have no idea what I'm doing

a2f2d30

Add ignore

f00c72e

philipp-spiess commented Jun 14, 2023

View reviewed changes

philipp-spiess merged commit 16be058 into main Jun 14, 2023
23 checks passed

philipp-spiess deleted the ps/cody-statusbar-item branch June 14, 2023 10:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cody: Add status bar item #53307

Cody: Add status bar item #53307

philipp-spiess commented Jun 12, 2023 •

edited

umpox left a comment

abeatrix left a comment •

edited

toolmantim commented Jun 13, 2023

philipp-spiess commented Jun 13, 2023

philipp-spiess commented Jun 13, 2023

toolmantim commented Jun 13, 2023 •

edited

toolmantim commented Jun 13, 2023

philipp-spiess commented Jun 13, 2023

toolmantim commented Jun 13, 2023

toolmantim commented Jun 13, 2023

philipp-spiess commented Jun 13, 2023

philipp-spiess commented Jun 14, 2023

philipp-spiess Jun 14, 2023

abeatrix Jun 14, 2023

philipp-spiess Jun 14, 2023

sourcegraph-bot commented Jun 14, 2023

Cody: Add status bar item #53307

Cody: Add status bar item #53307

Conversation

philipp-spiess commented Jun 12, 2023 • edited

Test plan

umpox left a comment

Choose a reason for hiding this comment

abeatrix left a comment • edited

Choose a reason for hiding this comment

toolmantim commented Jun 13, 2023

philipp-spiess commented Jun 13, 2023

philipp-spiess commented Jun 13, 2023

toolmantim commented Jun 13, 2023 • edited

toolmantim commented Jun 13, 2023

philipp-spiess commented Jun 13, 2023

toolmantim commented Jun 13, 2023

toolmantim commented Jun 13, 2023

philipp-spiess commented Jun 13, 2023

philipp-spiess commented Jun 14, 2023

philipp-spiess Jun 14, 2023

Choose a reason for hiding this comment

abeatrix Jun 14, 2023

Choose a reason for hiding this comment

philipp-spiess Jun 14, 2023

Choose a reason for hiding this comment

sourcegraph-bot commented Jun 14, 2023

philipp-spiess commented Jun 12, 2023 •

edited

abeatrix left a comment •

edited

toolmantim commented Jun 13, 2023 •

edited