Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cody: Simplify command related UI #53395

Merged
merged 5 commits into from
Jun 14, 2023
Merged

Cody: Simplify command related UI #53395

merged 5 commits into from
Jun 14, 2023

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Jun 13, 2023

Description

BEFORE AFTER
image image
image image
image image (No change)

Uses category to simplify how our commands appear in VS Code. Docs

Presentation of contributed commands depends on the containing menu. The Command Palette, for instance, prefixes commands with their category, allowing for easy grouping. However, the Command Palette doesn't show icons nor disabled commands. The editor context menu, on the other hand, shows disabled items but doesn't show the category label.

Test plan

Run locally
Check command related UX:

  • Hover
  • Menus
  • Quick Picks

@cla-bot cla-bot bot added the cla-signed label Jun 13, 2023
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label Jun 13, 2023
@umpox umpox requested review from philipp-spiess, abeatrix and a team June 13, 2023 14:28
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jun 13, 2023

📖 Storybook live preview

@toolmantim
Copy link
Contributor

Yesss… love that you're cleaning this up.

Can we use this as a chance to move away from "Ask Cody" and just have either the following for the editor context menu:

  • Cody
    • Fixup
    • Recipes
      • xxx
      • yyy
      • zzz
    • Touch

or:

  • Cody
    • Fixup
    • Recipe: xxx
    • Recipe: yyy
    • Recipe: zzz
    • Touch

@toolmantim
Copy link
Contributor

Also I don't think "Touch" is meant to appear in that editor context menu? I just tested, and it doesn't do anything for me.

@umpox
Copy link
Contributor Author

umpox commented Jun 14, 2023

Also I don't think "Touch" is meant to appear in that editor context menu? I just tested, and it doesn't do anything for me.

@toolmantim Looks like a bug, should only show when inline assist is enabled - I'll fix that

EDIT: Seems to be fixed from merging in main now. Can't replicate myself - Think it's because we recently added additional config for enabling/disabling inline assist

@umpox
Copy link
Contributor Author

umpox commented Jun 14, 2023

@toolmantim I would but actually touch and fixup are technically recipes too. Seems like it gets a bit blurry between what we consider a recipe and what isn't.

I can rename the "Ask Cody" menu to "Cody" and keep the current items as is, WDYT?

@umpox
Copy link
Contributor Author

umpox commented Jun 14, 2023

image

@umpox
Copy link
Contributor Author

umpox commented Jun 14, 2023

Will merge to push this forward, feel free to comment if you want to change anything!

@umpox umpox enabled auto-merge (squash) June 14, 2023 12:53
@umpox umpox merged commit 42a29ce into main Jun 14, 2023
15 of 16 checks passed
@umpox umpox deleted the tr/simplify-command-ui branch June 14, 2023 13:06
ErikaRS pushed a commit that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/code-exploration Issues owned by the Code Exploration team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants