Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Cody Inline Assist to Cody Inline Chat #53725

Merged
merged 2 commits into from
Jun 25, 2023
Merged

Rename Cody Inline Assist to Cody Inline Chat #53725

merged 2 commits into from
Jun 25, 2023

Conversation

toolmantim
Copy link
Contributor

As part of #53017 this renames "Inline Assist" to "Inline Chat"

Test plan

  • Run the automated tests
  • Manually created inline chats, and tested fixups from chats

@cla-bot cla-bot bot added the cla-signed label Jun 20, 2023
@toolmantim toolmantim mentioned this pull request Jun 20, 2023
Closed
9 tasks
@toolmantim
Copy link
Contributor Author

toolmantim commented Jun 20, 2023 •
edited

The only things that are not renamed are:

  • the user setting (cody.experimental.inline). And it didn't have the word "assist" in it
  • event logging

For the user setting, I'd suggest we do a follow up PR that changes this feature from experimental to beta, which is maybe a good time to change the name of the setting too?

Will defer to you @abeatrix @dominiccooney for what we do about event logging.

toolmantim
toolmantim commented Jun 20, 2023
View reviewed changes
client/cody/src/services/DecorationProvider.ts Outdated
@@ -56,15 +56,15 @@ export class DecorationProvider {
const rangeStartLine = getSingleLineRange(range.start.line)
if (this.status === CodyTaskState.error) {
this.decorationTypePending.dispose()
this.decorations.push({ range, hoverMessage: 'Failed Cody Assist #' + this.id })
this.decorations.push({ range, hoverMessage: 'Cody Inline Chat #' + this.id + ' failed' })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These text decorations seem a bit user-unfriendly, like they're for debugging purposes…

Screenshot 2023-06-20 at 2 57 34 pm

Maybe we condition them on cody.debug === true? Perhaps another PR?

@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jun 20, 2023 •
edited

📖 Storybook live preview

@abeatrix
Copy link
Contributor

The only things that are not renamed are:

  • the user setting (cody.experimental.inline). And it didn't have the word "assist" in it
  • event logging

For the user setting, I'd suggest we do a follow up PR that changes this feature from experimental to beta, which is maybe a good time to change the name of the setting too?

Will defer to you @abeatrix @dominiccooney for what we do about event logging.

thanks tim! I have a forgotten PR opened for replacing cody.experimental.inline. Will do that after your changes are merged

abeatrix
abeatrix approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim! Can you also notify the marketing team regarding this change since they have been using Inline Assist in all our marketing materials so far? 🙇‍♀️

@abeatrix
Copy link
Contributor

Btw this was the thread where the Marketing team went with Inline Assist instead of Inline Chat (sorry i just remember to about this 🙈) https://sourcegraph.slack.com/archives/C04NPH6SZMW/p1683742654437759

@toolmantim toolmantim enabled auto-merge (squash) June 20, 2023 13:18
@toolmantim toolmantim disabled auto-merge June 20, 2023 13:18
@toolmantim
Copy link
Contributor Author

Ah, okay. Will investigate tomorrow!

@toolmantim toolmantim force-pushed the tl/rename-inline-assist-to-inline-chat branch from ce18a86 to 548166d Compare June 25, 2023 01:04
@toolmantim
Copy link
Contributor Author

toolmantim commented Jun 25, 2023 •
edited

I've changed the diff to only be cosmetic… I'm leaving off any file/code rename changes for now, to avoid regressions and reduce merge conflicts this close to launch.

@toolmantim toolmantim force-pushed the tl/rename-inline-assist-to-inline-chat branch from 548166d to 2c17771 Compare June 25, 2023 01:29
@toolmantim toolmantim enabled auto-merge (squash) June 25, 2023 01:30
@toolmantim toolmantim merged commit aa1bc1b into main Jun 25, 2023
16 checks passed
@toolmantim toolmantim deleted the tl/rename-inline-assist-to-inline-chat branch June 25, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeatrix abeatrix abeatrix approved these changes

@dominiccooney dominiccooney Awaiting requested review from dominiccooney

Assignees
No one assigned
Labels
cla-signed cody/vscode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toolmantim @sourcegraph-bot @abeatrix