-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Cody Inline Assist to Cody Inline Chat #53725
Conversation
The only things that are not renamed are:
For the user setting, I'd suggest we do a follow up PR that changes this feature from Will defer to you @abeatrix @dominiccooney for what we do about event logging. |
@@ -56,15 +56,15 @@ export class DecorationProvider { | |||
const rangeStartLine = getSingleLineRange(range.start.line) | |||
if (this.status === CodyTaskState.error) { | |||
this.decorationTypePending.dispose() | |||
this.decorations.push({ range, hoverMessage: 'Failed Cody Assist #' + this.id }) | |||
this.decorations.push({ range, hoverMessage: 'Cody Inline Chat #' + this.id + ' failed' }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks tim! I have a forgotten PR opened for replacing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tim! Can you also notify the marketing team regarding this change since they have been using Inline Assist in all our marketing materials so far? 🙇♀️
Btw this was the thread where the Marketing team went with Inline Assist instead of Inline Chat (sorry i just remember to about this 🙈) https://sourcegraph.slack.com/archives/C04NPH6SZMW/p1683742654437759 |
Ah, okay. Will investigate tomorrow! |
ce18a86
to
548166d
Compare
I've changed the diff to only be cosmetic… I'm leaving off any file/code rename changes for now, to avoid regressions and reduce merge conflicts this close to launch. |
548166d
to
2c17771
Compare
As part of #53017 this renames "Inline Assist" to "Inline Chat"
Test plan