Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More compact Cody Chat Suggestions buttons #53755

Merged
merged 2 commits into from
Jun 20, 2023
Merged

More compact Cody Chat Suggestions buttons #53755

merged 2 commits into from
Jun 20, 2023

Conversation

toolmantim
Copy link
Contributor

This makes the suggestion buttons a little more compact for now (saves 50px vertical height on average)

Before After
Screenshot 2023-06-20 at 10 46 07 pm Screenshot 2023-06-20 at 10 46 57 pm

Test plan

  • Make the buttons appear
  • Interact with them

@cla-bot cla-bot bot added the cla-signed label Jun 20, 2023
philipp-spiess
philipp-spiess approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a change log entry but this is slick ✨

abeatrix
abeatrix approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the ✨ but it's much cleaner now :D

@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jun 20, 2023 •
edited
Loading

📖 Storybook live preview

@toolmantim toolmantim changed the title More compact Cody suggestion buttons More compact Cody Chat Suggestions buttons Jun 20, 2023
@toolmantim
Copy link
Contributor Author

I tried to get an icon in there, but failed! We’ll bring something back 😊

@toolmantim toolmantim enabled auto-merge (squash) June 20, 2023 13:13
@toolmantim toolmantim merged commit 66ff3a5 into main Jun 20, 2023
10 of 12 checks passed
@toolmantim toolmantim deleted the tl/make-suggestions-more-compact branch June 20, 2023 13:17
ErikaRS pushed a commit that referenced this pull request Jun 22, 2023
@toolmantim @ErikaRS
More compact Cody Chat Suggestions buttons (#53755)
5f72d8e 
This makes the suggestion buttons a little more compact for now (saves
50px vertical height on average)

| Before | After |
| - | - |
| <img width="322" alt="Screenshot 2023-06-20 at 10 46 07 pm"
src="https://github.com/sourcegraph/sourcegraph/assets/153/65df0187-366b-429b-8ff2-7571a4040f61">
|<img width="322" alt="Screenshot 2023-06-20 at 10 46 57 pm"
src="https://github.com/sourcegraph/sourcegraph/assets/153/15f88959-a2c6-492f-9325-d72e04ddd66a">
|

## Test plan

- Make the buttons appear
- Interact with them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

@abeatrix abeatrix abeatrix approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@toolmantim @sourcegraph-bot @philipp-spiess @abeatrix