-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cody: auto signin with app #53908
cody: auto signin with app #53908
Conversation
Yesterday's app release includes the app.json file I tested against that version and it was very smooth. One nit was when App was installed but not running, it properly told me, but the start app option was the last one, felt like that should have been since it knew that I had app. When pressing the Open App button I landed here in app which I was surprised by @marekweb is this the generate a new token page? Maybe we can adjust that deep link because I don't think that should be necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested against the latest app version and 👍 it was really smooth just opened right up and ready to go.
The "open app if not running" flow requires a click in App which I don't think should be necessary, so there is probably something there to work out maybe App needs another deep link that just returns right back to the extension.
@@ -0,0 +1,34 @@ | |||
export const LOCAL_APP_LOCATIONS: LocalAppPaths = { | |||
darwin: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder we should add the linux paths here too
@chwarwick the login page you're seeing is the old one so it has three options. The new login page is hidden behind a flag but if you set Cody.experimental.app.connect to true in your vs code user settings and reload vs code again, you should be able see the new page with only app as an option 😀 |
Co-authored-by: Marek <marek@sourcegraph.com>
Sign in user automatically when:
it also stores the token from the local file to secret storage automatically when found
Test plan
See Loom:
Cody.App.__.Editor.Auth.Flow.-.app.json.mp4