[fix] permission sync is now scheduled correctly for new users #54258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we relied on users_with_no_perms query to schedule new users. However this might not schedule anything for the new user, because the user might already have permissions granted from pending permissions. This resulted in sync job for the user never reaching the permission_sync_jobs table in the database. Which in turn also resulted in user not getting the permissions that they needed as fast as possible. It also resutled in scheduled permission syncs not being scheduled at all for the user, since the schedule depends on a record in permission_sync_jobs table for each user.
pjlast
approved these changes
Jun 27, 2023
keegancsmith
pushed a commit
that referenced
this pull request
Jun 27, 2023
Previously we relied on users_with_no_perms query to schedule new users. However this might not schedule anything for the new user, because the user might already have permissions granted from pending permissions. This resulted in sync job for the user never reaching the permission_sync_jobs table in the database. Which in turn also resulted in user not getting the permissions that they needed as fast as possible. It also resutled in scheduled permission syncs not being scheduled at all for the user, since the schedule depends on a record in permission_sync_jobs table for each user. ## Test plan unit tests (cherry picked from commit c68432a)
keegancsmith
pushed a commit
that referenced
this pull request
Jun 27, 2023
…ew users (#54274) Previously we relied on users_with_no_perms query to schedule new users. However this might not schedule anything for the new user, because the user might already have permissions granted from pending permissions. This resulted in sync job for the user never reaching the permission_sync_jobs table in the database. Which in turn also resulted in user not getting the permissions that they needed as fast as possible. It also resutled in scheduled permission syncs not being scheduled at all for the user, since the schedule depends on a record in permission_sync_jobs table for each user. ## Test plan unit tests <br> Backport c68432a from #54258 Co-authored-by: Milan Freml <kopancek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we relied on users_with_no_perms query to schedule new users. However this might not schedule anything for the new user, because the user might already have permissions granted from pending permissions.
This resulted in sync job for the user never reaching the permission_sync_jobs table in the database. Which in turn also resulted in user not getting the permissions that they needed as fast as possible. It also resutled in scheduled permission syncs not being scheduled at all for the user, since the schedule depends on a record in permission_sync_jobs table for each user.
Test plan
unit tests